linux-kernel - Re: [PATCH v1 6/9] hwmon: Add Nuvoton NCT6694 HWMON support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241028185414.65456203@jic23-huawei>
Date: Mon, 28 Oct 2024 18:54:14 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Ming Yu <a0282524688@...il.com>
Cc: Guenter Roeck <linux@...ck-us.net>, Kalesh Anakkur Purayil
 <kalesh-anakkur.purayil@...adcom.com>, tmyu0@...oton.com, lee@...nel.org,
 linus.walleij@...aro.org, brgl@...ev.pl, andi.shyti@...nel.org,
 mkl@...gutronix.de, mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, wim@...ux-watchdog.org, jdelvare@...e.com,
 lars@...afoo.de, ukleinek@...nel.org, alexandre.belloni@...tlin.com,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-iio@...r.kernel.org,
 linux-pwm@...r.kernel.org, linux-rtc@...r.kernel.org
Subject: Re: [PATCH v1 6/9] hwmon: Add Nuvoton NCT6694 HWMON support

On Mon, 28 Oct 2024 15:58:00 +0800
Ming Yu <a0282524688@...il.com> wrote:

> Dear Guenter,
> 
> The original plan was to use the IIO driver to access the temperature
> and voltage sensors, and the HWMON driver to access the tachometers.
> However, since the device is a hot-plug USB device, as far as I know,
> IIO-HWMON is not applicable. I will merge the IIO driver part into the
> HWMON driver in the next patch.
> In  other words, the driver will be used to access TIN, VIN and FIN.
See drivers/mfd/sun4i-gpadc.c
for an example of an mfd using the iio-hwmon bridge.

Jonathan

> 
> Best regards
> Ming
> 
> Guenter Roeck <linux@...ck-us.net> 於 2024年10月26日 週六 下午10:50寫道：
> >
> > On 10/25/24 08:44, Guenter Roeck wrote:  
> > > On 10/25/24 08:22, Ming Yu wrote:
> > > [ ... ]
> > >  
> > >>>>> +static int nct6694_fan_write(struct device *dev, u32 attr, int channel,
> > >>>>> +                            long val)
> > >>>>> +{
> > >>>>> +       struct nct6694_hwmon_data *data = dev_get_drvdata(dev);
> > >>>>> +       unsigned char enable_buf[REQUEST_HWMON_CMD0_LEN] = {0};  
> > >>>> [Kalesh] Please try to maintain RCT order for variable declaration  
> > >>>
> > >>> Ok, but that is already the case here ?  
> > >>
> > >> [Ming] Is there anything that needs to be changed?
> > >>  
> > >
> > > I don't think so, If two lines have the same length, the order is up
> > > to the developer to decide.
> > >
> > > Question though is if the buffer needs to be initialized. You should drop
> > > the initialization if it is not necessary. In that case the second line
> > > would be shorter anyway, and the order question would not arise.
> > >  
> >
> > Actually, I just noticed that you also submitted an IIO driver which
> > reports the same data again. If a chip has an IIO driver, there should
> > be no HWMON driver since the IIO -> HWMON bridge can then be used if
> > necessary. So please drop this driver.
> >
> > Thanks,
> > Guenter
> >
> >  
>