linux-kernel - Re: [PATCH v2 1/2] jiffies: Define secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZ+=W-PG5RqVVuoT=TVrcQ3qYaF79TfBP6nAzG1R4DaoAw@mail.gmail.com>
Date: Mon, 28 Oct 2024 15:25:21 -0400
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, 
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, linux-hyperv@...r.kernel.org, 
	Anna-Maria Behnsen <anna-maria@...utronix.de>, Thomas Gleixner <tglx@...utronix.de>, 
	Geert Uytterhoeven <geert@...ux-m68k.org>, Marcel Holtmann <marcel@...tmann.org>, 
	Johan Hedberg <johan.hedberg@...il.com>, linux-bluetooth@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Michael Kelley <mhklinux@...look.com>
Subject: Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

Hi Easwar,

On Mon, Oct 28, 2024 at 3:11 PM Easwar Hariharan
<eahariha@...ux.microsoft.com> wrote:
>
> secs_to_jiffies() is defined in hci_event.c and cannot be reused by
> other call sites. Hoist it into the core code to allow conversion of the
> ~1150 usages of msecs_to_jiffies() that either:
> - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or
> - have timeouts that are denominated in seconds (i.e. end in 000)
>
> This will also allow conversion of yet more sites that use (sec * HZ)
> directly, and improve their readability.
>
> TO: "K. Y. Srinivasan" <kys@...rosoft.com>
> TO: Haiyang Zhang <haiyangz@...rosoft.com>
> TO: Wei Liu <wei.liu@...nel.org>
> TO: Dexuan Cui <decui@...rosoft.com>
> TO: linux-hyperv@...r.kernel.org
> TO: Anna-Maria Behnsen <anna-maria@...utronix.de>
> TO: Thomas Gleixner <tglx@...utronix.de>
> TO: Geert Uytterhoeven <geert@...ux-m68k.org>
> TO: Marcel Holtmann <marcel@...tmann.org>
> TO: Johan Hedberg <johan.hedberg@...il.com>
> TO: Luiz Augusto von Dentz <luiz.dentz@...il.com>
> TO: linux-bluetooth@...r.kernel.org
> TO: linux-kernel@...r.kernel.org
> Suggested-by: Michael Kelley <mhklinux@...look.com>
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> ---
>  include/linux/jiffies.h   | 2 ++
>  net/bluetooth/hci_event.c | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h
> index 1220f0fbe5bf..e5256bb5f851 100644
> --- a/include/linux/jiffies.h
> +++ b/include/linux/jiffies.h
> @@ -526,6 +526,8 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m)
>         }
>  }
>
> +#define secs_to_jiffies(_secs) ((_secs) * HZ)
> +
>  extern unsigned long __usecs_to_jiffies(const unsigned int u);
>  #if !(USEC_PER_SEC % HZ)
>  static inline unsigned long _usecs_to_jiffies(const unsigned int u)
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 0bbad90ddd6f..7b35c58bbbeb 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -42,8 +42,6 @@
>  #define ZERO_KEY "\x00\x00\x00\x00\x00\x00\x00\x00" \
>                  "\x00\x00\x00\x00\x00\x00\x00\x00"
>
> -#define secs_to_jiffies(_secs) msecs_to_jiffies((_secs) * 1000)
> -
>  /* Handle HCI Event packets */
>
>  static void *hci_ev_skb_pull(struct hci_dev *hdev, struct sk_buff *skb,
>
> --
> 2.34.1
>

Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>

-- 
Luiz Augusto von Dentz