linux-kernel - Re: [PATCH] drivers: iio: adc: ad777x depends on CRC8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241028200442.4169b6f3@jic23-huawei>
Date: Mon, 28 Oct 2024 20:04:42 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Ramona Alexandra Nechita <ramona.nechita@...log.com>, Arnd Bergmann
 <arnd@...db.de>, Lars-Peter Clausen <lars@...afoo.de>, Nuno Sa
 <nuno.sa@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: iio: adc: ad777x depends on CRC8

On Mon, 28 Oct 2024 16:29:15 +0000
Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added driver fails to link when CONFIG_CRC8 is not set:
> 
> ld.lld-20: error: undefined symbol: crc8_populate_msb
> ld.lld-20: error: undefined symbol: crc8
> >>>               vmlinux.o:(ad7779_spi_read)  
> 
> Select this from Kconfig as we do for other drivers like it.
> 
> Fixes: cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Squashed into original patch.

Thanks!

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index d8abe28eec89..849c90203071 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -290,6 +290,7 @@ config AD7768_1
>  config AD7779
>  	tristate "Analog Devices AD7779 ADC driver"
>  	depends on SPI
> +	select CRC8
>  	select IIO_BUFFER
>  	help
>  	  Say yes here to build support for Analog Devices AD777X family