[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <98dd3fbf970559de8b7559da312e22fc@manjaro.org>
Date: Mon, 28 Oct 2024 21:44:37 +0100
From: Dragan Simic <dsimic@...jaro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Aren Moynihan <aren@...cevolution.org>, Jonathan Cameron
<jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec
<jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, Kaustabh
Chakraborty <kauschluss@...root.org>, Barnabás Czémán <trabarni@...il.com>, Ondrej Jirman <megi@....cz>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, phone-devel@...r.kernel.org
Subject: Re: [PATCH v3 3/6] iio: light: stk3310: Implement vdd and leda
supplies
Hello Aren,
On 2024-10-28 15:38, Andy Shevchenko wrote:
> On Mon, Oct 28, 2024 at 10:19:57AM -0400, Aren Moynihan wrote:
>> The vdd and leda supplies must be powered on for the chip to function
>> and can be powered off during system suspend.
>>
>> Co-developed-by: Ondrej Jirman <megi@....cz>
>
> Missing SoB. Please, read Submitting Patches documentation for
> understanding
> what has to be done here.
>
>> Signed-off-by: Aren Moynihan <aren@...cevolution.org>
>
> ...
>
>> Notes:
>> I'm not sure what the proper way to handle attribution for this
>> patch
>> is. It was origionally based on a patch by Ondrej Jirman[1], but I
>> have
>> rewritten a large portion if it. I have included a Co-developed-by
>> tag
>> to indicate this, but haven't sent him this patch, so I'm not sure
>> what
>> to do about a Signed-off-by.
>
> Ah, seems you already aware of this issue. So, either drop
> Co-developed-by
> (and if you wish you may give a credit in a free form inside commit
> message)
> or make sure you get his SoB tag.
Perhaps the best and also easiest solution would be to provide an
Originally-by tag for Ondrej, because that's what it is. The patch
was written originally by Ondrej, but you've changed many parts of
the patch while upstreaming it.
Powered by blists - more mailing lists