linux-kernel - Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024102855-untitled-unfixed-2b9d@gregkh>
Date: Mon, 28 Oct 2024 06:26:04 +0100
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"saravanak@...gle.com" <saravanak@...gle.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Seiya Wang (王迺君) <seiya.wang@...iatek.com>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>
Subject: Re: [PATCH] Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"

On Mon, Oct 28, 2024 at 02:38:49AM +0000, Jason-JH Lin (林睿祥) wrote:
> On Thu, 2024-10-24 at 12:23 +0200, gregkh@...uxfoundation.org wrote:
> >  	 
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
> > > Hi Greg,
> > > 
> > > Thanks for your information.
> > > 
> > > On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
> > > >   
> > > > External email : Please do not click links or open attachments
> > until
> > > > you have verified the sender or the content.
> > > >  On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4
> > Relay
> > > > wrote:
> > > > > From: "Jason-JH.Lin" <jason-jh.lin@...iatek.com>
> > > > > 
> > > > > This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
> > > > > 
> > > > > Reason for revert:
> > > > > 1. The commit [1] does not land on linux-5.15, so this patch
> > does
> > > > not
> > > > > fix anything.
> > > > > 
> > > > > 2. Since the fw_device improvements series [2] does not land on
> > > > > linux-5.15, using device_set_fwnode() causes the panel to flash
> > > > during
> > > > > bootup.
> > > > > 
> > > > > Incorrect link management may lead to incorrect device
> > > > initialization,
> > > > > affecting firmware node links and consumer relationships.
> > > > > The fwnode setting of panel to the DSI device would cause a DSI
> > > > > initialization error without series[2], so this patch was
> > reverted
> > > > to
> > > > > avoid using the incomplete fw_devlink functionality.
> > > > > 
> > > > > [1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > > detection more robust")
> > > > > [2] Link: 
> > > > 
> > https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
> > > > > 
> > > 
> > > Please don't mind me make a confirmation.
> > > I just need to add this line here and send it again, right?
> > > 
> > > Cc: <stable@...r.kernel.org> #5.15.169
> > 
> > Yes.
> 
> Hi Greg,
> 
> Thanks for your confirmation!
> 
> I've sent the patch again without adding `v2` after the [PATCH]:
> https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.com
> Would that be fine with you?

But it is a v2 patch, why not mark it as such?