linux-kernel - Re: [PATCH 2/2] pinctrl: qcom: Add sm8750 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b18028d1-43cc-4106-b33e-37480979eb97@quicinc.com>
Date: Mon, 28 Oct 2024 14:28:31 -0700
From: Melody Olvera <quic_molvera@...cinc.com>
To: Linus Walleij <linus.walleij@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Satya Durga Srinivasu Prabhala
	<quic_satyap@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: qcom: Add sm8750 pinctrl driver



On 10/25/2024 1:43 AM, Linus Walleij wrote:
> On Wed, Oct 23, 2024 at 8:18 PM Melody Olvera <quic_molvera@...cinc.com> wrote:
>> On 10/22/2024 8:27 PM, Bjorn Andersson wrote:
>>> On Mon, Oct 21, 2024 at 04:04:14PM GMT, Melody Olvera wrote:
>>> [..]
>>>> +static const int sm8750_reserved_gpios[] = {
>>>> +    36, 37, 38, 39, 74, -1
>>> Any particular reason why these are not gpio-reserved-ranges in
>>> DeviceTree?
>>>
>> Not particularly; I wasn't sure whether or not to include in the initial
>> dt patch.
>> Will add.
> Can we also write (as a comment in the device tree) *why* they
> are reserved? Such as "used by BIOS/ACPI/secure world"?
> Just a minor nit but it's very helpful for newcomers reading the
> DTS.
>

For sure; yeah these are reserved for secure world, but I'll make note 
of that in the tree.

Thanks,
Melody