linux-kernel - Re: [PATCH] pmdomain: core: fix "sd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo0PpqvSHVgL3AaFQUR7B=+MqzCqkg4+t2Rt3nidQzYRw@mail.gmail.com>
Date: Mon, 28 Oct 2024 22:51:00 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com, 
	Michael Trimarchi <michael@...rulasolutions.com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH] pmdomain: core: fix "sd_count" field setting

On Mon, 28 Oct 2024 at 16:07, Dario Binacchi
<dario.binacchi@...rulasolutions.com> wrote:
>
> On Mon, Oct 28, 2024 at 2:34 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
> >
> > On Thu, 24 Oct 2024 at 11:49, Dario Binacchi
> > <dario.binacchi@...rulasolutions.com> wrote:
> > >
> > > The "sd_count" field keeps track of the number of subdomains with power
> > > "on," so if pm_genpd_init() is called with the "is_off" parameter set to
> > > false, it means that the power domain is already on, and therefore its
> > > "sd_count" must be 1.
> >
> > genpd_sd_counter_inc() is being called when adding subdomains. Doesn't
> > that work correctly for you?
>
> In my use case the genpd_add_subdomain() is not called.
> I am working on :
> drivers/pmdomain/imx/gpcv2.c
> drivers/pmdomain/imx/imx8m-blk-ctrl.c

In that case you don't have a child-domain (subdomain), which means
the sd_count should be 0.

[...]

Kind regards
Uffe