linux-kernel - Re: [PATCH v1 1/1] gpio: Use traditional pattern when checking error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbfhbtUmmE9M3qLuM8LmPDYKvZL_znVnvGqGZwSB0=Nbw@mail.gmail.com>
Date: Mon, 28 Oct 2024 23:10:29 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpio: Use traditional pattern when checking error codes

On Mon, Oct 28, 2024 at 2:44 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:

> Instead of 'if (ret == 0)' switch to "check for the error first" rule.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

This makes a lot of sense.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij