linux-kernel - Re: [PATCH v1 03/10] media: platform: mediatek: add isp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <133fb2170dd636f9eaa9bf3d91f2ed10f17f1213.camel@mediatek.com>
Date: Mon, 28 Oct 2024 01:30:26 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
	"christian.koenig@....com" <christian.koenig@....com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Shu-hsiang Yang (楊舒翔)
	<Shu-hsiang.Yang@...iatek.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"yunkec@...omium.org" <yunkec@...omium.org>, "linaro-mm-sig@...ts.linaro.org"
	<linaro-mm-sig@...ts.linaro.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Yaya Chang (張雅清)
	<Yaya.Chang@...iatek.com>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Teddy Chen (陳乾元) <Teddy.Chen@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "hidenorik@...omium.org"
	<hidenorik@...omium.org>, Shun-Yi Wang (王順億)
	<Shun-Yi.Wang@...iatek.com>
Subject: Re: [PATCH v1 03/10] media: platform: mediatek: add isp_7x seninf
 unit

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces the driver of the MediaTek Sensor Interface,
> focusing on integration with the MediaTek ISP CAMSYS. The
> seninf device bridges camera sensors and the ISP system,
> providing management for sensor data routing and processing.
> Key features include V4L2 framework control, and dynamic
> handling of stream configurations and virtual channels.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@...iatek.com>
> ---

[snip]

> +enum VC_FEATURE {
> +	VC_NONE = 0,
> +	VC_MIN_NUM,
> +	VC_RAW_DATA = VC_MIN_NUM,
> +	VC_RAW_DATA_MAX,
> +
> +	VC_PDAF_MIN_NUM = VC_RAW_DATA_MAX,
> +	VC_PDAF_STATS = VC_PDAF_MIN_NUM,
> +	VC_PDAF_STATS_NE,
> +	VC_PDAF_STATS_ME,
> +	VC_PDAF_STATS_SE,
> +	VC_PDAF_STATS_PIX_1,
> +	VC_PDAF_STATS_PIX_2,
> +	VC_PDAF_STATS_NE_PIX_1 = VC_PDAF_STATS_PIX_1,
> +	VC_PDAF_STATS_NE_PIX_2 = VC_PDAF_STATS_PIX_2,
> +	VC_PDAF_STATS_ME_PIX_1,
> +	VC_PDAF_STATS_ME_PIX_2,
> +	VC_PDAF_STATS_SE_PIX_1,

VC_PDAF_STATS_SE_PIX_1 is useless, so drop it.

Regards,
CK

> +	VC_PDAF_STATS_SE_PIX_2,
> +	VC_PDAF_MAX_NUM,
> +
> +	VC_HDR_MIN_NUM = VC_PDAF_MAX_NUM,
> +	VC_HDR_MVHDR = VC_HDR_MIN_NUM,
> +	VC_HDR_MAX_NUM,
> +
> +	VC_3HDR_MIN_NUM = VC_HDR_MAX_NUM,
> +	VC_3HDR_EMBEDDED = VC_3HDR_MIN_NUM,
> +	VC_3HDR_FLICKER,
> +	VC_3HDR_Y,
> +	VC_3HDR_AE,
> +	VC_3HDR_MAX_NUM,
> +
> +	VC_STAGGER_MIN_NUM = VC_3HDR_MAX_NUM,
> +	VC_STAGGER_EMBEDDED = VC_STAGGER_MIN_NUM,
> +	VC_STAGGER_NE,
> +	VC_STAGGER_ME,
> +	VC_STAGGER_SE,
> +	VC_STAGGER_MAX_NUM,
> +
> +	VC_YUV_MIN_NUM = VC_STAGGER_MAX_NUM,
> +	VC_YUV_Y = VC_YUV_MIN_NUM,
> +	VC_YUV_UV,
> +	VC_YUV_MAX_NUM,
> +
> +	VC_RAW_EXT_MIN_NUM = VC_YUV_MAX_NUM,
> +	VC_RAW_W_DATA = VC_RAW_EXT_MIN_NUM,
> +	VC_RAW_PROCESSED_DATA,
> +	VC_RAW_EXT_MAX_NUM,
> +
> +	VC_GENERAL_DATA_MIN_NUM = VC_RAW_EXT_MAX_NUM,
> +	VC_GENERAL_EMBEDDED = VC_GENERAL_DATA_MIN_NUM,
> +	VC_GENERAL_DATA_MAX_NUM,
> +
> +	VC_MAX_NUM = VC_GENERAL_DATA_MAX_NUM,
> +};
> +