[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c6dce2c7-5233-40a0-a530-fd6b31a3f694@kernel.org>
Date: Mon, 28 Oct 2024 08:30:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Markuss Broks <markuss.broks@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Linus Walleij <linus.walleij@...aro.org>, Tomasz Figa
<tomasz.figa@...il.com>, Will Deacon <will@...nel.org>,
Mark Rutland <mark.rutland@....com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
linux-gpio@...r.kernel.org, Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
Maksym Holovach <nergzd@...gzd723.xyz>
Subject: Re: [PATCH v3 08/10] pinctrl: samsung: Add Exynos9810 SoC specific
data
On 26/10/2024 22:32, Markuss Broks wrote:
> +};
> +
> +/* pin banks of exynos9810 pin-controller 2 (CHUB) */
> +static const struct samsung_pin_bank_data exynos9810_pin_banks2[] __initconst = {
> + EXYNOS850_PIN_BANK_EINTG(8, 0x000, "gph0", 0x00),
> + EXYNOS850_PIN_BANK_EINTG(5, 0x020, "gph1", 0x04),
> +};
> +
> +/* pin banks of exynos9810 pin-controller 3 (CMGP) */
> +static const struct samsung_pin_bank_data exynos9810_pin_banks3[] __initconst = {
> + EXYNOS850_PIN_BANK_EINTW(1, 0x000, "gpm0", 0x00),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x020, "gpm1", 0x04),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x040, "gpm2", 0x08),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x060, "gpm3", 0x0C),
> + EXYNOS850_PIN_BANK_EINTW(1, 0x080, "gpm4", 0x10),
How did you implement previous feedback about lowercase hex?
Best regards,
Krzysztof
Powered by blists - more mailing lists