| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <cover.1729864823.git.namcao@linutronix.de>
Date: Mon, 28 Oct 2024 08:31:33 +0100
From: Nam Cao <namcao@...utronix.de>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>,
Frederic Weisbecker <frederic@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>,
Miguel Ojeda <ojeda@...nel.org>,
Kees Cook <kees@...nel.org>,
linux-kernel@...r.kernel.org
Cc: Nam Cao <namcao@...utronix.de>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Michael Ellerman <mpe@...erman.id.au>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sean Christopherson <seanjc@...gle.com>,
Marc Zyngier <maz@...nel.org>,
Huacai Chen <chenhuacai@...nel.org>,
Anup Patel <anup@...infault.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Russell King <linux@...linux.org.uk>,
Peter Zijlstra <peterz@...radead.org>,
"Paul E. McKenney" <paulmck@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Jens Axboe <axboe@...nel.dk>,
Oleg Nesterov <oleg@...hat.com>,
Christian Brauner <brauner@...nel.org>,
John Stultz <jstultz@...gle.com>,
Alexei Starovoitov <ast@...nel.org>,
Richard Weinberger <richard@....at>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Steven Rostedt <rostedt@...dmis.org>,
Damien Le Moal <dlemoal@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Herbert Xu <herbert@...dor.apana.org.au>
Subject: [PATCH 00/31] hrtimers: Switch to new hrtimer interface functions (2/5)
This is the second part of a 5-part series (split for convenience). All 5
parts are:
Part 1: https://lore.kernel.org/lkml/cover.1729864615.git.namcao@linutronix.de
Part 2: https://lore.kernel.org/lkml/cover.1729864823.git.namcao@linutronix.de
Part 3: https://lore.kernel.org/lkml/cover.1729865232.git.namcao@linutronix.de
Part 4: https://lore.kernel.org/lkml/cover.1729865485.git.namcao@linutronix.de
Part 5: https://lore.kernel.org/lkml/cover.1729865740.git.namcao@linutronix.de
To use hrtimer, hrtimer_init() (or one of its variant) must be called, and
also the timer's callfack function must be setup separately.
That can cause misuse of hrtimer. For example, because:
- The callback function is not setup
- The callback function is setup while it is not safe to do so
To prevent misuse of hrtimer, this series:
- Introduce new functions hrtimer_setup*(). These new functions are
similar to hrtimer_init*(), except that they also sanity-check and
initialize the callback function.
- Introduce hrtimer_update_function() which checks that it is safe to
change the callback function. The 'function' field of hrtimer is then
made private.
- Convert all users to use the new functions.
- Some minor cleanups on the way.
Most conversion patches were created using Coccinelle with the sematic
patch below; except for tricky cases that Coccinelle cannot handle, or for
some cases where a Coccinelle's bug regarding 100 column limit is
triggered. Any patches not mentioning Coccinelle were done manually.
virtual patch
@@ expression timer, clock, mode, func; @@
- hrtimer_init(timer, clock, mode);
...
- timer->function = func;
+ hrtimer_setup(timer, func, clock, mode);
@@ expression timer, clock, mode, func; @@
- hrtimer_init(&timer, clock, mode);
...
- timer.function = func;
+ hrtimer_setup(&timer, func, clock, mode);
@@ expression timer, clock, mode, func; @@
- hrtimer_init_on_stack(&timer, clock, mode);
...
- timer.function = func;
+ hrtimer_setup_on_stack(&timer, func, clock, mode);
@@ expression timer, clock, mode; @@
- hrtimer_init_sleeper_on_stack(timer, clock, mode);
+ hrtimer_setup_sleeper_on_stack(timer, clock, mode);
Signed-off-by: Nam Cao <namcao@...utronix.de>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Michael Ellerman <mpe@...erman.id.au>
Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
Cc: Sean Christopherson <seanjc@...gle.com>
Cc: Marc Zyngier <maz@...nel.org>
Cc: Huacai Chen <chenhuacai@...nel.org>
Cc: Anup Patel <anup@...infault.org>
Cc: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Russell King <linux@...linux.org.uk>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: "Paul E. McKenney" <paulmck@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Jens Axboe <axboe@...nel.dk>
Cc: Oleg Nesterov <oleg@...hat.com>
Cc: Christian Brauner <brauner@...nel.org>
Cc: John Stultz <jstultz@...gle.com>
Cc: Alexei Starovoitov <ast@...nel.org>
Cc: Richard Weinberger <richard@....at>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Damien Le Moal <dlemoal@...nel.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Heiko Stuebner <heiko@...ech.de>
Cc: Herbert Xu <herbert@...dor.apana.org.au>
Nam Cao (31):
KVM: MIPS: Switch to use hrtimer_setup()
KVM: PPC: Switch to use hrtimer_setup()
KVM: s390: Switch to use hrtimer_setup()
KVM: x86: Switch to use hrtimer_setup()
KVM: arm64: Switch to use hrtimer_setup()
LoongArch: KVM: Switch to use hrtimer_setup()
riscv: kvm: Switch to use hrtimer_setup()
ARM: imx: Switch to use hrtimer_setup()
ARM: 8611/1: l2x0: Switch to use hrtimer_setup()
powerpc/watchdog: Switch to use hrtimer_setup()
perf/x86: Switch to use hrtimer_setup()
s390/ap_bus: Switch to use hrtimer_setup()
sched: Switch to use hrtimer_setup()
rcu: Switch to use hrtimer_setup()
lib: test_objpool: Switch to use hrtimer_setup()
io_uring/timeout: Switch to use hrtimer_setup()
fork: Switch to use hrtimer_setup()
perf: Switch to use hrtimer_setup()
timerfd: Switch to use hrtimer_setup()
time: Switch to hrtimer_setup()
bpf: Switch to use hrtimer_setup()
ubifs: Switch to use hrtimer_setup()
watchdog: Switch to use hrtimer_setup()
tracing/osnoise: Switch to use hrtimer_setup()
block, bfq: Switch to use hrtimer_setup()
ata: pata_octeon_cf: Switch to use hrtimer_setup()
blk_iocost: Switch to use hrtimer_setup()
PM: runtime: Switch to use hrtimer_setup()
PM / devfreq: rockchip-dfi: Switch to use hrtimer_setup()
null_blk: Switch to use hrtimer_setup()
hwrng: timeriomem: Switch to use hrtimer_setup()
arch/arm/mach-imx/mmdc.c | 5 ++---
arch/arm/mm/cache-l2x0-pmu.c | 3 +--
arch/arm64/kvm/arch_timer.c | 7 +++----
arch/loongarch/kvm/vcpu.c | 4 ++--
arch/mips/kvm/mips.c | 5 ++---
arch/powerpc/kernel/watchdog.c | 3 +--
arch/powerpc/kvm/powerpc.c | 4 ++--
arch/riscv/kvm/vcpu_timer.c | 7 ++++---
arch/s390/kvm/interrupt.c | 3 +--
arch/s390/kvm/kvm-s390.c | 4 ++--
arch/x86/events/intel/uncore.c | 3 +--
arch/x86/events/rapl.c | 3 +--
arch/x86/kvm/hyperv.c | 3 +--
arch/x86/kvm/i8254.c | 3 +--
arch/x86/kvm/lapic.c | 5 ++---
arch/x86/kvm/vmx/nested.c | 5 ++---
arch/x86/kvm/xen.c | 5 ++---
block/bfq-iosched.c | 5 ++---
block/blk-iocost.c | 3 +--
drivers/ata/pata_octeon_cf.c | 5 ++---
drivers/base/power/runtime.c | 4 ++--
drivers/block/null_blk/main.c | 7 +++----
drivers/char/hw_random/timeriomem-rng.c | 3 +--
drivers/devfreq/event/rockchip-dfi.c | 3 +--
drivers/s390/crypto/ap_bus.c | 3 +--
drivers/watchdog/softdog.c | 8 +++-----
drivers/watchdog/watchdog_dev.c | 4 ++--
drivers/watchdog/watchdog_hrtimer_pretimeout.c | 4 ++--
fs/timerfd.c | 5 ++---
fs/ubifs/io.c | 3 +--
io_uring/timeout.c | 13 ++++++-------
kernel/bpf/helpers.c | 3 +--
kernel/events/core.c | 7 +++----
kernel/fork.c | 3 +--
kernel/rcu/tree.c | 4 ++--
kernel/sched/core.c | 3 +--
kernel/sched/deadline.c | 6 ++----
kernel/sched/fair.c | 8 ++++----
kernel/sched/rt.c | 5 ++---
kernel/time/ntp.c | 3 +--
kernel/time/posix-timers.c | 7 +++----
kernel/time/sched_clock.c | 3 +--
kernel/time/tick-broadcast-hrtimer.c | 3 +--
kernel/time/tick-sched.c | 6 ++----
kernel/trace/trace_osnoise.c | 6 ++----
kernel/watchdog.c | 3 +--
lib/test_objpool.c | 3 +--
47 files changed, 87 insertions(+), 128 deletions(-)
--
2.39.5
Powered by blists - more mailing lists