linux-kernel - Re: [PATCH 2/6] dt-bindings: iio: dac: ad5791: Add required voltage supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <oy25ajhj7hgg2lk6i2xpkceisoveloc6i6z5sank44jc7i4f6k@xpqgqjpcgn34>
Date: Mon, 28 Oct 2024 09:06:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ahaslam@...libre.com
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org, 
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, nuno.sa@...log.com, 
	dlechner@...libre.com, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: iio: dac: ad5791: Add required voltage
 supplies

On Mon, Oct 28, 2024 at 08:11:14AM +0100, ahaslam@...libre.com wrote:
> From: Axel Haslam <ahaslam@...libre.com>
> 
> Vcc, iovcc, vrefp, and vrefn are needed for the DAC to work.
> Add them as required bindings for ad5791.
> 
> Signed-off-by: Axel Haslam <ahaslam@...libre.com>
> ---
>  .../bindings/iio/dac/adi,ad5791.yaml          | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> index fe664378c966..79cb4b78a88a 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> @@ -26,6 +26,22 @@ properties:
>    vdd-supply: true
>    vss-supply: true
>  
> +  vcc-supply:
> +    description:
> +      Supply that powers the chip.
> +
> +  iovcc-supply:
> +    description:
> +      Supply for the digital interface.
> +
> +  vrefp-supply:
> +    description:
> +      Positive referance input voltage range. From 5v to (vdd - 2.5)
> +
> +  vrefn-supply:
> +    description:
> +      Negative referance input voltage range. From (vss + 2.5) to 0.
> +
>    adi,rbuf-gain2-en:
>      description: Specify to allow an external amplifier to be connected in a
>        gain of two configuration.
> @@ -47,6 +63,10 @@ required:
>    - reg
>    - vdd-supply
>    - vss-supply
> +  - vcc-supply
> +  - iovcc-supply
> +  - vrefp-supply
> +  - vrefn-supply

So you have six required supplies?

Datasheet says "A voltage range of 2.7 V to 5.5 V *can* be connected",
so doesn't it mean this is optional? Although similar wording is for
other supplies, so maybe it's just imprecise language?

Best regards,
Krzysztof