[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <28280e94-3d2b-4687-aef2-24a9f5893f8e@linux.ibm.com>
Date: Mon, 28 Oct 2024 14:09:44 +0530
From: Madadi Vineeth Reddy <vineethr@...ux.ibm.com>
To: Benjamin Tang <tangsong8264@...il.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Juri Lelli <juri.lelli@...hat.com>,
Dietmar Eggemann <dietmar.eggemann@....com>,
linux-kernel@...r.kernel.org,
Madadi Vineeth Reddy <vineethr@...ux.ibm.com>
Subject: Re: [PATCH] sched: Remove unused parameter from update_deadline()
On 15/10/24 19:08, Benjamin Tang wrote:
>
> After commit 85e511df3cec ("sched/eevdf: Allow shorter slices
> to wakeup-preempt"), the 'cfs_rq' argument is no longer used
> in update_deadline(). Remove it.
>
Yes, cfs_rq argument is not used anymore.
Reviewed-by: Madadi Vineeth Reddy <vineethr@...ux.ibm.com>
Thanks,
Madadi Vineeth Reddy
> Signed-off-by: Benjamin Tang <tangsong8264@...il.com>
> ---
> kernel/sched/fair.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d9c33f6c1d54..882802d79720 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1004,7 +1004,7 @@ static void clear_buddies(struct cfs_rq *cfs_rq, struct sched_entity *se);
> * XXX: strictly: vd_i += N*r_i/w_i such that: vd_i > ve_i
> * this is probably good enough.
> */
> -static bool update_deadline(struct cfs_rq *cfs_rq, struct sched_entity *se)
> +static bool update_deadline(struct sched_entity *se)
> {
> if ((s64)(se->vruntime - se->deadline) < 0)
> return false;
> @@ -1228,7 +1228,7 @@ static void update_curr(struct cfs_rq *cfs_rq)
> return;
>
> curr->vruntime += calc_delta_fair(delta_exec, curr);
> - resched = update_deadline(cfs_rq, curr);
> + resched = update_deadline(curr);
> update_min_vruntime(cfs_rq);
>
> if (entity_is_task(curr)) {
> --
> 2.11.0
Powered by blists - more mailing lists