linux-kernel - Re: [PATCH next] media: raspberrypi: Do some cleanup in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <332e84d1-72fe-4a0c-8686-8cd838af09a0@ideasonboard.com>
Date: Mon, 28 Oct 2024 11:22:50 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Naushir Patuck <naush@...pberrypi.com>, linux-media@...r.kernel.org,
 linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] media: raspberrypi: Do some cleanup in probe()

Hi,

On 23/10/2024 11:30, Dan Carpenter wrote:
> If devm_clk_get() fails then we need to free "cfe" before returning.
> 
> Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> index 045910de6c57..1da58b07c1d3 100644
> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> @@ -2343,9 +2343,11 @@ static int cfe_probe(struct platform_device *pdev)
>   
>   	/* TODO: Enable clock only when running. */
>   	cfe->clk = devm_clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(cfe->clk))
> -		return dev_err_probe(&pdev->dev, PTR_ERR(cfe->clk),
> -				     "clock not found\n");
> +	if (IS_ERR(cfe->clk)) {
> +		ret = dev_err_probe(&pdev->dev, PTR_ERR(cfe->clk),
> +				    "clock not found\n");
> +		goto err_cfe_put;
> +	}
>   
>   	cfe->mdev.dev = &pdev->dev;
>   	cfe->mdev.ops = &cfe_media_device_ops;

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

  Tomi