linux-kernel - Re: [PATCH v4 1/4] iio: imu: bmi270: Add triggered buffer for Bosch BMI270 IMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zx9Ycjnlef1RJfGf@smile.fi.intel.com>
Date: Mon, 28 Oct 2024 11:25:06 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Justin Weiss <justin@...tinweiss.com>
Cc: Alex Lanzano <lanzano.alex@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Derek J . Clark" <derekjohn.clark@...il.com>,
	Philip Müller <philm@...jaro.org>
Subject: Re: [PATCH v4 1/4] iio: imu: bmi270: Add triggered buffer for Bosch
 BMI270 IMU

On Sun, Oct 27, 2024 at 10:20:22AM -0700, Justin Weiss wrote:
> Set up a triggered buffer for the accel and angl_vel values.

...

>  	.channel2 = IIO_MOD_##_axis,				\
>  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
> +	.scan_index = BMI270_SCAN_ACCEL_##_axis,		\
> +	.scan_type = {						\
> +		.sign = 's',					\
> +		.realbits = 16,					\
> +		.storagebits = 16,				\
> +		.endianness = IIO_LE				\

Leave trailing comma here.

> +	},	                                                \

...

>  	.channel2 = IIO_MOD_##_axis,				\
>  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
> +	.scan_index = BMI270_SCAN_GYRO_##_axis,			\
> +	.scan_type = {						\
> +		.sign = 's',					\
> +		.realbits = 16,					\
> +		.storagebits = 16,				\
> +		.endianness = IIO_LE				\

Ditto.

> +	},	                                                \

-- 
With Best Regards,
Andy Shevchenko