linux-kernel - Re: [PATCH] mfd: cgbc-core: Fix error handling paths in cgbc_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09e7baa9-8715-4f9c-924b-3e782dd3196f@bootlin.com>
Date: Mon, 28 Oct 2024 10:31:35 +0100
From: Thomas Richard <thomas.richard@...tlin.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mfd: cgbc-core: Fix error handling paths in
 cgbc_init_device()

Hello Christophe,

On 10/26/24 12:32, Christophe JAILLET wrote:
> If an error occurs after a cgbc_session_request() call, it should be
> balanced by a corresponding cgbc_session_release(), as already done in the
> remove function.
> 
> Fixes: 6f1067cfbee7 ("mfd: Add Congatec Board Controller driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only
> ---
>  drivers/mfd/cgbc-core.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
> index 93004a6b29c1..7771d010eb2e 100644
> --- a/drivers/mfd/cgbc-core.c
> +++ b/drivers/mfd/cgbc-core.c
> @@ -321,9 +321,19 @@ static int cgbc_init_device(struct cgbc_device_data *cgbc)
>  
>  	ret = cgbc_get_version(cgbc);
>  	if (ret)
> -		return ret;
> +		goto release_session;
> +
> +	ret = mfd_add_devices(cgbc->dev, -1, cgbc_devs, ARRAY_SIZE(cgbc_devs),
> +			      NULL, 0, NULL);
> +	if (ret)
> +		goto release_session;
> +
> +	return 0;
> +
> +release_session:
> +	cgbc_session_release(cgbc);
> +	return ret;
>  
> -	return mfd_add_devices(cgbc->dev, -1, cgbc_devs, ARRAY_SIZE(cgbc_devs), NULL, 0, NULL);
>  }

nitpick: useless blank line before the close brace.

Reviewed-by: Thomas Richard <thomas.richard@...tlin.com>

Regards,

Thomas