linux-kernel - Re: [PATCH] staging: gpib: Fix error handling paths in cb_gpib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47d10f3f-3741-4a84-a1a5-8cd03bc22396@bootlin.com>
Date: Mon, 28 Oct 2024 10:40:02 +0100
From: Thomas Richard <thomas.richard@...tlin.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Dave Penkler <dpenkler@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: gpib: Fix error handling paths in
 cb_gpib_probe()

Hello Christophe,

On 10/26/24 13:03, Christophe JAILLET wrote:
> If cb_gpib_config() fails, 'info' needs to be freed, as already done in the
> remove function.
> 
> While at it, remove a pointless comment related to gpib_attach().
> 
> Fixes: 6f1067cfbee7 ("mfd: Add Congatec Board Controller driver")

The Fixes tag is not correct.
I guess you did a wrong copy-paste as you sent a patch for the CGBC MFD
driver few minutes before :)

Regards,

Thomas