linux-kernel - Re: [PATCH linux-next] ice: use string choice helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca4f7990-16c4-42ef-b0ae-12e64a100f5e@intel.com>
Date: Mon, 28 Oct 2024 10:54:33 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: R Sundar <prosunofficial@...il.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <karol.kolacinski@...el.com>,
	<arkadiusz.kubalewski@...el.com>, <jacob.e.keller@...el.com>, "kernel test
 robot" <lkp@...el.com>, Julia Lawall <julia.lawall@...ia.fr>, Andrew Lunn
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH linux-next] ice: use string choice helpers

On 10/27/24 15:19, R Sundar wrote:
> Use string choice helpers for better readability.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> Closes: https://lore.kernel.org/r/202410121553.SRNFzc2M-lkp@intel.com/
> Signed-off-by: R Sundar <prosunofficial@...il.com>
> ---

thanks, this indeed covers all "enabled/disabled" cases, so:
Acked-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

for future submissions for Intel Ethernet drivers please use the
iwl-next (or iwl-net) target trees.

There are also other cases that we could cover ON/OFF etc

> 
> Reported in linux repository.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> 
> cocci warnings: (new ones prefixed by >>)
>>> drivers/net/ethernet/intel/ice/ice_ptp_hw.c:396:4-22: opportunity for str_enabled_disabled(dw24 . ts_pll_enable)
>     drivers/net/ethernet/intel/ice/ice_ptp_hw.c:474:4-22: opportunity for str_enabled_disabled(dw24 . ts_pll_enable)
> 
> vim +396 drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> 
> 
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> index da88c6ccfaeb..d8d3395e49c3 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
> @@ -393,7 +393,7 @@ static int ice_cfg_cgu_pll_e82x(struct ice_hw *hw,
>   
>   	/* Log the current clock configuration */
>   	ice_debug(hw, ICE_DBG_PTP, "Current CGU configuration -- %s, clk_src %s, clk_freq %s, PLL %s\n",
> -		  dw24.ts_pll_enable ? "enabled" : "disabled",
> +		  str_enabled_disabled(dw24.ts_pll_enable),
>   		  ice_clk_src_str(dw24.time_ref_sel),
>   		  ice_clk_freq_str(dw9.time_ref_freq_sel),
>   		  bwm_lf.plllock_true_lock_cri ? "locked" : "unlocked");

perhaps locked/unlocked could be added into string_choices.h

> @@ -471,7 +471,7 @@ static int ice_cfg_cgu_pll_e82x(struct ice_hw *hw,
>   
>   	/* Log the current clock configuration */
>   	ice_debug(hw, ICE_DBG_PTP, "New CGU configuration -- %s, clk_src %s, clk_freq %s, PLL %s\n",
> -		  dw24.ts_pll_enable ? "enabled" : "disabled",
> +		  str_enabled_disabled(dw24.ts_pll_enable),
>   		  ice_clk_src_str(dw24.time_ref_sel),
>   		  ice_clk_freq_str(dw9.time_ref_freq_sel),
>   		  bwm_lf.plllock_true_lock_cri ? "locked" : "unlocked");
> @@ -548,7 +548,7 @@ static int ice_cfg_cgu_pll_e825c(struct ice_hw *hw,
>   
>   	/* Log the current clock configuration */
>   	ice_debug(hw, ICE_DBG_PTP, "Current CGU configuration -- %s, clk_src %s, clk_freq %s, PLL %s\n",
> -		  dw24.ts_pll_enable ? "enabled" : "disabled",
> +		  str_enabled_disabled(dw24.ts_pll_enable),
>   		  ice_clk_src_str(dw23.time_ref_sel),
>   		  ice_clk_freq_str(dw9.time_ref_freq_sel),
>   		  ro_lock.plllock_true_lock_cri ? "locked" : "unlocked");
> @@ -653,7 +653,7 @@ static int ice_cfg_cgu_pll_e825c(struct ice_hw *hw,
>   
>   	/* Log the current clock configuration */
>   	ice_debug(hw, ICE_DBG_PTP, "New CGU configuration -- %s, clk_src %s, clk_freq %s, PLL %s\n",
> -		  dw24.ts_pll_enable ? "enabled" : "disabled",
> +		  str_enabled_disabled(dw24.ts_pll_enable),
>   		  ice_clk_src_str(dw23.time_ref_sel),
>   		  ice_clk_freq_str(dw9.time_ref_freq_sel),
>   		  ro_lock.plllock_true_lock_cri ? "locked" : "unlocked");