Message-ID: <6278651d-b61d-49d2-8151-7ab4ca03971c@riseup.net>
Date: Mon, 28 Oct 2024 07:17:04 -0300
From: Maíra Canal <mairacanal@...eup.net>
To: Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
 Melissa Wen <melissa.srw@...il.com>,
 Haneen Mohammed <hamohammed.sa@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Jonathan Corbet <corbet@....net>,
 Simona Vetter <simona@...ll.ch>, rdunlap@...radead.org,
 arthurgrillo@...eup.net, pekka.paalanen@...oniitty.fi,
 Simona Vetter <simona.vetter@...ll.ch>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 thomas.petazzoni@...tlin.com, jeremie.dautheribes@...tlin.com,
 miquel.raynal@...tlin.com, seanpaul@...gle.com, marcheu@...gle.com,
 nicolejadeyee@...gle.com
Subject: Re: [PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify

Hi Louis,

On 28/10/24 06:50, Louis Chauvet wrote:
> On 26/10/24 - 09:10, Maíra Canal wrote:
>> Hi Louis,
>>
>> On 14/10/24 05:39, Louis Chauvet wrote:
>>> On 11/10/24 - 10:53, Maira Canal wrote:
>>>> Hi Louis,
>>>>
>>>> On 10/11/24 06:36, Louis Chauvet wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> Until this point, this series has not received any major comments since
>>>>> v9. I will commit patches 1-9 next week if there are no further comments.
>>>>>
>>>>
>>>> Although we are maintainers of VKMS, it isn't recommended that we push
>>>> our own changes without even the Ack of another person. Please, read the
>>>> "drm-misc Committer Guidelines" [1].
>>>
>>> Hi Maíra, Maxime,
>>>
>>> I apologize for this rushed commit request. I sent the initial email with
>>> a delay before the commit action because I was not sure about the
>>> procedure and wanted to give others a chance to raise any concerns.
>>> Unfortunately, I overlooked the need to collect an Ack/Review for each
>>> patch, even when there hadn't been any responses for several months. I'm
>>> sorry for this oversight.
>>>
>>>> I can ack patches 05/15, 07/15, and 09/15, but it would be more
>>>> beneficial for the community if you ask for an ack (from me or from the
>>>> DRM maintainers, which are always around), instead of saying that you
>>>> are going to commit the patches without any review.
>>>
>>> I will be happy to ask for acknowledgments if needed, but as you mentioned
>>> multiple times: nobody is paid to maintain VKMS. Since you did not comment
>>> these series since July, when you told me you would review my patches, I
>>> assumed it was either okay or you no longer had the time to maintain
>>> (which I completely understand).
>>
>> Yeah, I'm a volunteer and no longer have time to maintain VKMS. A couple
>> of weeks ago I sent a patch removing myself as VKMS maintainer. This
>> doesn't imply that patches can be pushed without review.
> 
> I will acked-by and push your patch, it will be an easy "first commit". If
> I do something wrong during the process, please tell me.
> 
> Thanks for this precision, I understood this, and I will not push without
> reviews, don't worry!
> 
> Thanks a lot for all your reviews!
>   
>> We are a community with several active developers. Although I don't have
>> time to properly review your patches, you can try to gather other
>> developers to review your patches. You can try to use #dri-devel to get
>> reviewers.
> 
> Thanks for the tip, I will do this!
> 
>> That said, you can add my ACK to patches 05/15, 07/15, and 09/15 and
>> push the patches. I won't ack the YUV patches as I don't feel
>> comfortable reviewing/acking those.
> 
> Perfect for the patches 1..9, it will be a very nice step forward and will
> reduce my conflicts a lot with the rest of my work!
 > >> Acked-by: Maíra Canal <mairacanal@...eup.net>
>>
>> BTW if the patches are fixing IGT tests, please update the list of fails
>> and skips on DRM CI.
> 
> For this, how should I do? Commit the series and wait for the bot results?
> Run tests on my computer (I only have a x86 VM)? Is there some doc
> somewhere?

Check [1] for instructions on how to run the CI on GitLab.

[1] https://docs.kernel.org/gpu/automated_testing.html

Best Regards,
- Maíra

> 
> Thanks a lot,
> Louis Chauvet
> 
>> Best Regards,
>> - Maíra
>>
>>>
>>> So, I hereby formally request reviews/ACKs for the following series:
>>>
>>> [this series]:https://lore.kernel.org/all/20241007-yuv-v12-0-01c1ada6fec8@bootlin.com/
>>> [2]:https://lore.kernel.org/all/20241007-b4-new-color-formats-v2-0-d47da50d4674@bootlin.com/
>>> [3]:https://lore.kernel.org/all/20240516-writeback_line_by_line-v1-0-7b2e3bf9f1c9@bootlin.com/
>>>
>>> (I have to send a v2 for [3] because of rebase conflict, but nothing else
>>> changed)
>>>
>>> Thanks a lot,
>>> Louis Chauvet
>>>> [1] https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html
>>>>
>>>> Best Regards,
>>>> - Maíra
>>>>
>>>>> For patches 10-15, I am currently waiting for feedback from Maxime to
>>>>> send the next iteration with a fix for kunit tests.
>>>>>
>>>>> Thanks,
>>>>> Louis Chauvet
>>>>>
>>>>> On 07/10/24 - 18:10, Louis Chauvet wrote:
>>>>>> As all the rotation are now supported by VKMS, this simplification does
>>>>>> not make sense anymore, so remove it.
>>>>>>
>>>>>> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
>>>>>> ---
>>>>>>     drivers/gpu/drm/vkms/vkms_plane.c | 7 +------
>>>>>>     1 file changed, 1 insertion(+), 6 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
>>>>>> index 8875bed76410..5a028ee96c91 100644
>>>>>> --- a/drivers/gpu/drm/vkms/vkms_plane.c
>>>>>> +++ b/drivers/gpu/drm/vkms/vkms_plane.c
>>>>>> @@ -115,12 +115,7 @@ static void vkms_plane_atomic_update(struct drm_plane *plane,
>>>>>>     	frame_info->fb = fb;
>>>>>>     	memcpy(&frame_info->map, &shadow_plane_state->data, sizeof(frame_info->map));
>>>>>>     	drm_framebuffer_get(frame_info->fb);
>>>>>> -	frame_info->rotation = drm_rotation_simplify(new_state->rotation, DRM_MODE_ROTATE_0 |
>>>>>> -									  DRM_MODE_ROTATE_90 |
>>>>>> -									  DRM_MODE_ROTATE_270 |
>>>>>> -									  DRM_MODE_REFLECT_X |
>>>>>> -									  DRM_MODE_REFLECT_Y);
>>>>>> -
>>>>>> +	frame_info->rotation = new_state->rotation;
>>>>>>     	vkms_plane_state->pixel_read_line = get_pixel_read_line_function(fmt);
>>>>>>     }
>>>>>>
>>>>>> -- 
>>>>>> 2.46.2
>>>>>>

Powered by blists - more mailing lists