linux-kernel - Re: [PATCH v2 1/2] crypto: hisilicon/sec2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zx9o4zaq11gPhhE8@gondor.apana.org.au>
Date: Mon, 28 Oct 2024 18:35:15 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "linwenkai (C)" <linwenkai6@...ilicon.com>
Cc: Chenghai Huang <huangchenghai2@...wei.com>, davem@...emloft.net,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	liulongfang@...wei.com, shenyang39@...wei.com, qianweili@...wei.com,
	wangzhou1@...ilicon.com
Subject: Re: [PATCH v2 1/2] crypto: hisilicon/sec2 - fix for aead icv error

On Mon, Oct 28, 2024 at 10:03:40AM +0800, linwenkai (C) wrote:
>
> Finally If you think the variable is not needed, I can delete it and use
> crypto_aead_authsize to get it every time.

Just call crypto_aead_authsize from the places where you need it.
There is no point in making another copy of authsize.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt