linux-kernel - Re: [PATCH 00/44] hrtimers: Switch to new hrtimer interface functions (4/5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7xc32r5.ffs@tglx>
Date: Mon, 28 Oct 2024 12:06:54 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Nam Cao
 <namcao@...utronix.de>, Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Frederic Weisbecker <frederic@...nel.org>, Andreas Hindborg
 <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda
 <ojeda@...nel.org>, Kees Cook <kees@...nel.org>,
 linux-kernel@...r.kernel.org
Cc: Nam Cao <namcao@...utronix.de>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, "Martin K. Petersen"
 <martin.petersen@...cle.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Sebastian Reichel
 <sre@...nel.org>, Will Deacon <will@...nel.org>, Jon Mason
 <jdmason@...zu.us>, Jaehoon Chung <jh80.chung@...sung.com>, Hans Verkuil
 <hverkuil-cisco@...all.nl>, Jassi Brar <jassisinghbrar@...il.com>, Pavel
 Machek <pavel@....cz>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Jonathan Cameron <jic23@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Alex Deucher <alexander.deucher@....com>, Jani Nikula
 <jani.nikula@...ux.intel.com>, Rob Clark <robdclark@...il.com>, Lucas De
 Marchi <lucas.demarchi@...el.com>, Zack Rusin <zack.rusin@...adcom.com>,
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>, Uwe
 Kleine-König <ukleinek@...nel.org>, Takashi Iwai
 <tiwai@...e.com>,
 alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH 00/44] hrtimers: Switch to new hrtimer interface
 functions (4/5)

On Mon, Oct 28 2024 at 10:58, Alexander Shishkin wrote:
> Nam Cao <namcao@...utronix.de> writes:
>
>> This is the forth part of a 5-part series (split for convenience). All 5
>> parts are:
>>
>> Part 1: https://lore.kernel.org/lkml/cover.1729864615.git.namcao@linutronix.de
>> Part 2: https://lore.kernel.org/lkml/cover.1729864823.git.namcao@linutronix.de
>> Part 3: https://lore.kernel.org/lkml/cover.1729865232.git.namcao@linutronix.de
>> Part 4: https://lore.kernel.org/lkml/cover.1729865485.git.namcao@linutronix.de
>> Part 5: https://lore.kernel.org/lkml/cover.1729865740.git.namcao@linutronix.de
>
> Which one do I need to click on to see the actual hrtimer_setup*()
> implementations? Why is it even a separate series? Please, don't make
> people click on things.

Obviously part 1. The splitup was dont to avoid 500+ people which is
generally frowned upon.

>> That can cause misuse of hrtimer. For example, because:
>>   - The callback function is not setup
>>   - The callback function is setup while it is not safe to do so
>
> These are not examples, these are hypotheticals. Do either of these
> things actually happen in the codebase?

Right now not, but we had this in the past.

>> To prevent misuse of hrtimer, this series:
>>   - Introduce new functions hrtimer_setup*(). These new functions are
>>     similar to hrtimer_init*(), except that they also sanity-check and
>>     initialize the callback function.

> I'm not objecting to the idea, it's just carried out weirdly.

Right. There should have been a sectioning to explain what which part of
the series does. My bad.

Thanks,

        tglx