linux-kernel - Re: [PATCH 2/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode in the SD Express process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFoTAiniLRBpDv91HVf94_GJ=REhS52tqeNi+ptDXGGtyw@mail.gmail.com>
Date: Mon, 28 Oct 2024 12:43:50 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Ben Chuang <benchuanggli@...il.com>
Cc: adrian.hunter@...el.com, victor.shih@...esyslogic.com.tw, 
	greg.tu@...esyslogic.com.tw, ben.chuang@...esyslogic.com.tw, 
	HL.Liu@...esyslogic.com.tw, Lucas.Lai@...esyslogic.com.tw, 
	victorshihgli@...il.com, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: sdhci-pci-gli: GL9767: Fix low power mode in the
 SD Express process

On Fri, 25 Oct 2024 at 08:01, Ben Chuang <benchuanggli@...il.com> wrote:
>
> From: Ben Chuang <ben.chuang@...esyslogic.com.tw>
>
> When starting the SD Express process, the low power negotiation mode will
> be disabled, so we need to re-enable it after switching back to SD mode.
>
> Fixes: 0e92aec2efa0 ("mmc: sdhci-pci-gli: Add support SD Express card for GL9767")
> Signed-off-by: Ben Chuang <benchuanggli@...il.com>

I am dropping this SoB, as we agreed for patch1 too.

> Signed-off-by: Ben Chuang <ben.chuang@...esyslogic.com.tw>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-pci-gli.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 22a927ce2c88..68ce4920e01e 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -1068,6 +1068,9 @@ static int gl9767_init_sd_express(struct mmc_host *mmc, struct mmc_ios *ios)
>                 sdhci_writew(host, value, SDHCI_CLOCK_CONTROL);
>         }
>
> +       pci_read_config_dword(pdev, PCIE_GLI_9767_CFG, &value);
> +       value &= ~PCIE_GLI_9767_CFG_LOW_PWR_OFF;
> +       pci_write_config_dword(pdev, PCIE_GLI_9767_CFG, value);
>         gl9767_vhs_read(pdev);
>
>         return 0;
> --
> 2.47.0
>