linux-kernel - [PATCH v2] crypto: qat - Fix missing destroy_workqueue in adf_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029150523.52435-1-wanghai38@huawei.com>
Date: Tue, 29 Oct 2024 23:05:23 +0800
From: Wang Hai <wanghai38@...wei.com>
To: <giovanni.cabiddu@...el.com>, <herbert@...dor.apana.org.au>,
	<davem@...emloft.net>, <ahsan.atta@...el.com>, <mun.chun.yep@...el.com>,
	<markas.rapoportas@...el.com>, <damian.muszynski@...el.com>,
	<furong.zhou@...el.com>, <adam.guerin@...el.com>, <zhangxiaoxu5@...wei.com>
CC: <qat-linux@...el.com>, <linux-crypto@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <wanghai38@...wei.com>
Subject: [PATCH v2] crypto: qat - Fix missing destroy_workqueue in adf_init_aer()

The adf_init_aer() won't destroy device_reset_wq when alloc_workqueue()
for device_sriov_wq failed. Add destroy_workqueue for device_reset_wq to
fix this issue.

Fixes: 4469f9b23468 ("crypto: qat - re-enable sriov after pf reset")
Signed-off-by: Wang Hai <wanghai38@...wei.com>
---
v1->v2: add 'device_reset_wq = NULL'
 drivers/crypto/intel/qat/qat_common/adf_aer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/intel/qat/qat_common/adf_aer.c b/drivers/crypto/intel/qat/qat_common/adf_aer.c
index ec7913ab00a2..4cb8bd83f570 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_aer.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_aer.c
@@ -281,8 +281,11 @@ int adf_init_aer(void)
 		return -EFAULT;
 
 	device_sriov_wq = alloc_workqueue("qat_device_sriov_wq", 0, 0);
-	if (!device_sriov_wq)
+	if (!device_sriov_wq) {
+		destroy_workqueue(device_reset_wq);
+		device_reset_wq = NULL;
 		return -EFAULT;
+	}
 
 	return 0;
 }
-- 
2.17.1