linux-kernel - Re: [PATCH 1/1] Compiler Attributes: disable __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3ADD56B1-9BBF-48CD-81C7-53E10675F566@toblux.com>
Date: Tue, 29 Oct 2024 16:10:32 +0100
From: Thorsten Blum <thorsten.blum@...lux.com>
To: Jan Hendrik Farr <kernel@...rr.cc>
Cc: kees@...nel.org,
 nathan@...nel.org,
 ojeda@...nel.org,
 ndesaulniers@...gle.com,
 morbo@...gle.com,
 justinstitt@...gle.com,
 ardb@...nel.org,
 oliver.sang@...el.com,
 gustavoars@...nel.org,
 kent.overstreet@...ux.dev,
 arnd@...db.de,
 gregkh@...uxfoundation.org,
 akpm@...ux-foundation.org,
 tavianator@...ianator.com,
 linux-hardening@...r.kernel.org,
 llvm@...ts.linux.dev,
 linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH 1/1] Compiler Attributes: disable __counted_by for clang <
 19.1.3

On 29. Oct 2024, at 15:00, Jan Hendrik Farr wrote:
> 
> This patch disables __counted_by for clang versions < 19.1.3 because
> of the two issues listed below. It does this by introducing
> CONFIG_CC_HAS_COUNTED_BY.
> 
> 1. clang < 19.1.2 has a bug that can lead to __bdos returning 0:
> https://github.com/llvm/llvm-project/pull/110497
> 
> 2. clang < 19.1.3 has a bug that can lead to __bdos being off by 4:
> https://github.com/llvm/llvm-project/pull/112636
> 
> Fixes: c8248faf3ca2 ("Compiler Attributes: counted_by: Adjust name and identifier expansion")
> Cc: stable@...r.kernel.org # 6.6.x: 16c31dd7fdf6: Compiler Attributes: counted_by: bump min gcc version
> Cc: stable@...r.kernel.org # 6.6.x: 2993eb7a8d34: Compiler Attributes: counted_by: fixup clang URL
> Cc: stable@...r.kernel.org # 6.6.x: 231dc3f0c936: lkdtm/bugs: Improve warning message for compilers without counted_by support
> Cc: stable@...r.kernel.org # 6.6.x
> Reported-by: Nathan Chancellor <nathan@...nel.org>
> Closes: https://lore.kernel.org/all/20240913164630.GA4091534@thelio-3990X/
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202409260949.a1254989-oliver.sang@intel.com
> Link: https://lore.kernel.org/all/Zw8iawAF5W2uzGuh@archlinux/T/#m204c09f63c076586a02d194b87dffc7e81b8de7b
> Suggested-by: Nathan Chancellor <nathan@...nel.org>
> Signed-off-by: Jan Hendrik Farr <kernel@...rr.cc>
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>
> Tested-by: Nathan Chancellor <nathan@...nel.org>
> Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Thanks for fixing this and your work on the Clang issues. Feel free to add:

Reviewed-by: Thorsten Blum <thorsten.blum@...ux.dev>