linux-kernel - Re: [PATCH] perf/arm_pmuv3: fix building on 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241029152928.GA4865@willie-the-truck>
Date: Tue, 29 Oct 2024 15:29:29 +0000
From: Will Deacon <will@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Mark Rutland <mark.rutland@....com>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, James Clark <james.clark@...aro.org>,
	Anshuman Khandual <anshuman.khandual@....com>,
	Ilkka Koskinen <ilkka@...amperecomputing.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf/arm_pmuv3: fix building on 32-bit

On Tue, Oct 29, 2024 at 03:24:10PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The write_pmuacr() function is only defined on arm64, so building the
> driver on 32-bit arm now fails:
> 
> drivers/perf/arm_pmuv3.c: In function 'armv8pmu_enable_user_access':
> drivers/perf/arm_pmuv3.c:784:17: error: implicit declaration of function 'write_pmuacr'; did you mean 'write_pmcr'? [-Wimplicit-function-declaration]
> 
> Add a compile-time check around the newly added code, as it is never
> needed on arm32.
> 
> Fixes: 0bbff9ed8165 ("perf/arm_pmuv3: Add PMUv3.9 per counter EL0 access control")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/perf/arm_pmuv3.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Cheers, Arnd. Rob already sent a fix for this [1], which I'll push out
shortly.

Will

[1] https://lore.kernel.org/linux-arm-kernel/20241029120602.4061566-2-robh@kernel.org/