linux-kernel - RE: [PATCH 03/16] x86/amd_nb: Clean up early_is_amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083AA7B2E28F2DA24E4B456FC4B2@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Tue, 29 Oct 2024 16:15:33 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Borislav Petkov <bp@...en8.de>, Yazen Ghannam <yazen.ghannam@....com>,
	Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
CC: "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>, "avadhut.naik@....com"
	<avadhut.naik@....com>, "john.allen@....com" <john.allen@....com>,
	"mario.limonciello@....com" <mario.limonciello@....com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "Shyam-sundar.S-k@....com"
	<Shyam-sundar.S-k@....com>, "richard.gong@....com" <richard.gong@....com>,
	"jdelvare@...e.com" <jdelvare@...e.com>, "linux@...ck-us.net"
	<linux@...ck-us.net>, "clemens@...isch.de" <clemens@...isch.de>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>, "ilpo.jarvinen@...ux.intel.com"
	<ilpo.jarvinen@...ux.intel.com>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "linux-hwmon@...r.kernel.org"
	<linux-hwmon@...r.kernel.org>, "platform-driver-x86@...r.kernel.org"
	<platform-driver-x86@...r.kernel.org>, "naveenkrishna.chatradhi@....com"
	<naveenkrishna.chatradhi@....com>, "carlos.bilbao.osdev@...il.com"
	<carlos.bilbao.osdev@...il.com>
Subject: RE: [PATCH 03/16] x86/amd_nb: Clean up early_is_amd_nb()

> > > > -       if (boot_cpu_data.x86_vendor == X86_VENDOR_HYGON)
> > > > -               misc_ids = hygon_nb_misc_ids;
> > > > +       if (boot_cpu_has(X86_FEATURE_ZEN))
> > >
> > > check_for_deprecated_apis: WARNING: arch/x86/kernel/amd_nb.c:395: Do not use boot_cpu_has() - use cpu_feature_enabled() instead.
> >
> > Sure thing.
> >
> > How can I enable this check myself?
> It is part of my silly patch checking script:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=vp
>
> in here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/tree/.tip/bin/vp.py?h=vp
>
> but it probably isn't ready for public consumption yet.
>
> I probably should try to package it properly when there's time...

Sounds like it would be a valuable addition to checkpatch.

Maybe Joe or Andy will find time before you do.

-Tony