[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZyELVe0EUZg9iD0q@hovoldconsulting.com>
Date: Tue, 29 Oct 2024 17:20:37 +0100
From: Johan Hovold <johan@...nel.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Felipe Balbi <balbi@...com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Lee Jones <lee@...nel.org>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
stable@...r.kernel.org, linux-phy@...ts.infradead.org,
linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2 2/6] phy: core: Fix that API
devm_of_phy_provider_unregister() fails to unregister the phy provider
On Tue, Oct 29, 2024 at 11:35:48PM +0800, Zijun Hu wrote:
> On 2024/10/29 21:43, Johan Hovold wrote:
> > And you could consider dropping the function altogether as well.
>
> Remove the API devm_of_phy_provider_unregister()?
>
> i prefer fixing it instead of removing it based on below considerations.
>
> 1) it is simper. just about one line change.
> 2) the API may be used in future. the similar API of [PATCH 1/6] have 2
> usages.
We typically don't carry APIs that no one uses (or has ever used), but
sure, that can be done separately later if anyone cares.
Johan
Powered by blists - more mailing lists