linux-kernel - RE: [PATCH v2 1/3] ARM: dts: aspeed: Add WDT controller into alias field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYZPR06MB5203A2F48CDDB1D80927021DB24B2@TYZPR06MB5203.apcprd06.prod.outlook.com>
Date: Tue, 29 Oct 2024 02:32:38 +0000
From: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>, "patrick@...cx.xyz"
	<patrick@...cx.xyz>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "joel@....id.au" <joel@....id.au>,
	"wim@...ux-watchdog.org" <wim@...ux-watchdog.org>, "linux@...ck-us.net"
	<linux@...ck-us.net>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-watchdog@...r.kernel.org"
	<linux-watchdog@...r.kernel.org>
CC: "Peter.Yin@...ntatw.com" <Peter.Yin@...ntatw.com>,
	"Patrick_NC_Lin@...ynn.com" <Patrick_NC_Lin@...ynn.com>,
	"Bonnie_Lo@...ynn.com" <Bonnie_Lo@...ynn.com>, "DELPHINE_CHIU@...ynn.com"
	<DELPHINE_CHIU@...ynn.com>, BMC-SW <BMC-SW@...eedtech.com>,
	"chnguyen@...erecomputing.com" <chnguyen@...erecomputing.com>
Subject: RE: [PATCH v2 1/3] ARM: dts: aspeed: Add WDT controller into alias
 field

Hi Andrew,

Thanks for the check.

> -----Original Message-----
> From: Andrew Jeffery <andrew@...econstruct.com.au>
> Sent: Tuesday, October 29, 2024 7:55 AM
> Subject: Re: [PATCH v2 1/3] ARM: dts: aspeed: Add WDT controller into alias
> field
> 
> On Mon, 2024-10-28 at 10:48 +0800, Chin-Ting Kuo wrote:
> > Add WDT controller into alias field. After that, WDT index, used to
> > distinguish different WDT controllers in the driver, can be gotten by
> > using of_alias_get_id dts API.
> 
> I feel it would be less brittle if we encode the mapping in the driver?
> Based on reg the driver can derive the watchdog index. That way there's no
> constraint on how the platform architect arranges the aliases for the
> watchdogs (if they define them at all).
> 

It is also a feasible approach. It will be changed in the next patch version.

> Andrew

Chin-Ting