linux-kernel - Re: [PATCH v2] bpf: fix filed access without lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173022422800.772061.4721556452097618907.git-patchwork-notify@kernel.org>
Date: Tue, 29 Oct 2024 17:50:28 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: mrpre <mrpre@....com>
Cc: xiyou.wangcong@...il.com, yonghong.song@...ux.dev,
 john.fastabend@...il.com, edumazet@...gle.com, jakub@...udflare.com,
 davem@...emloft.net, dsahern@...nel.org, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] bpf: fix filed access without lock

Hello:

This patch was applied to bpf/bpf.git (master)
by Martin KaFai Lau <martin.lau@...nel.org>:

On Mon, 28 Oct 2024 14:52:26 +0800 you wrote:
> The tcp_bpf_recvmsg_parser() function, running in user context,
> retrieves seq_copied from tcp_sk without holding the socket lock, and
> stores it in a local variable seq. However, the softirq context can
> modify tcp_sk->seq_copied concurrently, for example, n tcp_read_sock().
> 
> As a result, the seq value is stale when it is assigned back to
> tcp_sk->copied_seq at the end of tcp_bpf_recvmsg_parser(), leading to
> incorrect behavior.
> 
> [...]

Here is the summary with links:
  - [v2] bpf: fix filed access without lock
    https://git.kernel.org/bpf/bpf/c/2ce9abd6e1e1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html