linux-kernel - Re: [PATCH 1/3] drm/msm/dp: prefix all symbols with msm_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <584639e8-bad8-4083-8c84-c1edcd8fa14e@quicinc.com>
Date: Tue, 29 Oct 2024 11:05:40 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Rob Clark
	<robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, Simona
 Vetter <simona@...ll.ch>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        kernel
 test robot <lkp@...el.com>
Subject: Re: [PATCH 1/3] drm/msm/dp: prefix all symbols with msm_dp_



On 10/28/2024 4:49 AM, Dmitry Baryshkov wrote:
> For historical reasons a lot of symbols in the MSM DisplayPort driver
> used the generic dp_ prefix. Perform a mass-rename of those symbols to
> use msm_dp prefix.
> 
> Basically this is a result of the following script:
> 
> sed drivers/gpu/drm/msm/dp/* -i -e 's/\<dp_/msm_dp_/g'
> sed drivers/gpu/drm/msm/dp/* -i -e 's/"msm_dp_/"dp_/g'
> sed drivers/gpu/drm/msm/dp/* -i -e 's/msm_\(dp_sdp_header\|dp_sdp\)\>/\1/g'
> 
> Yes, this also results in renaming of several struct fields in addition
> to renaming the structs and functions, but I think the simple solution
> is better than the more complex one.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410250305.UHKDhtxy-lkp@intel.com/
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
>   drivers/gpu/drm/msm/dp/dp_audio.c   | 294 ++++++------
>   drivers/gpu/drm/msm/dp/dp_audio.h   |  38 +-
>   drivers/gpu/drm/msm/dp/dp_aux.c     | 148 +++---
>   drivers/gpu/drm/msm/dp/dp_aux.h     |  18 +-
>   drivers/gpu/drm/msm/dp/dp_catalog.c | 734 +++++++++++++++---------------
>   drivers/gpu/drm/msm/dp/dp_catalog.h | 118 ++---
>   drivers/gpu/drm/msm/dp/dp_ctrl.c    | 482 ++++++++++----------
>   drivers/gpu/drm/msm/dp/dp_ctrl.h    |  40 +-
>   drivers/gpu/drm/msm/dp/dp_debug.c   |  68 +--
>   drivers/gpu/drm/msm/dp/dp_debug.h   |  10 +-
>   drivers/gpu/drm/msm/dp/dp_display.c | 866 ++++++++++++++++++------------------
>   drivers/gpu/drm/msm/dp/dp_display.h |  18 +-
>   drivers/gpu/drm/msm/dp/dp_drm.c     | 108 ++---
>   drivers/gpu/drm/msm/dp/dp_drm.h     |  22 +-
>   drivers/gpu/drm/msm/dp/dp_link.c    | 432 +++++++++---------
>   drivers/gpu/drm/msm/dp/dp_link.h    |  44 +-
>   drivers/gpu/drm/msm/dp/dp_panel.c   | 254 +++++------
>   drivers/gpu/drm/msm/dp/dp_panel.h   |  42 +-
>   drivers/gpu/drm/msm/dp/dp_utils.c   |  20 +-
>   drivers/gpu/drm/msm/dp/dp_utils.h   |   8 +-
>   20 files changed, 1882 insertions(+), 1882 deletions(-)
> 

There is some WIP going on related to DP features, so we will need to 
rebase all of it but I think its better to get this in now rather than 
later, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>