linux-kernel - Re: [PATCH v6] rust: add global lock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mb9X0LiDtDe9ptbqm3Ls527Xp+szX7px+Zw6OP8-aefQ@mail.gmail.com>
Date: Tue, 29 Oct 2024 19:48:21 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Boqun Feng <boqun.feng@...il.com>
Cc: Alice Ryhl <aliceryhl@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, 
	Waiman Long <longman@...hat.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Andreas Hindborg <a.hindborg@...nel.org>
Subject: Re: [PATCH v6] rust: add global lock support

On Mon, Oct 28, 2024 at 6:49 PM Boqun Feng <boqun.feng@...il.com> wrote:
>
> Reviewed-by: Boqun Feng <boqun.feng@...il.com>
>
> In addition, I've also queued it in my lockdep-for-tip branch:
>
>         https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/log/?h=lockdep-for-tip
>
> as I want to help route Rust lock-related patches into tip, so this is
> a practice round for me ;-)
>
> Miguel, feel free to take it via rust-next with my Reviewed-by, I will
> drop it from my branch once if I see it shows up in v6.13-rc1.

No, no, it is great if you can take them :)

By "if I see it shows up in v6.13-rc1", do you mean your branch is not
meant for v6.13?

Couple of things I noticed that I would normally double-check/fix in
place: the "// SAFETY: called exactly once" comment could be
formatted, and I think the "Link:" tag should be before your SoB
(well, at least b4 does that, which makes sense since you added it,
but I have seen commits done differently too).

Thanks!

Cheers,
Miguel