[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <07039967-2BFC-4D84-AC3E-F98CD510BD3F@linux.vnet.ibm.com>
Date: Wed, 30 Oct 2024 00:25:00 +0530
From: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
To: Ian Rogers <irogers@...gle.com>, Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
Kan Liang <kan.liang@...ux.intel.com>,
James Clark <james.clark@...aro.org>,
Howard Chu <howardchu95@...il.com>,
Michael Petlan <mpetlan@...hat.com>,
Veronika Molnarova <vmolnaro@...hat.com>,
Dapeng Mi <dapeng1.mi@...ux.intel.com>,
Thomas Richter <tmricht@...ux.ibm.com>,
Ilya Leoshkevich <iii@...ux.ibm.com>,
Colin Ian King <colin.i.king@...il.com>,
Weilin Wang <weilin.wang@...el.com>, Andi Kleen <ak@...ux.intel.com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v5 00/10] Run tests in parallel showing number of tests
running
> On 26 Oct 2024, at 12:50 AM, Ian Rogers <irogers@...gle.com> wrote:
>
> Avoid waitpid so that stdout/stderr aren't destroyed prior to wanting
> to read them for display. When running on a color terminal, display
> the number of running tests (1 if sequential). To avoid previous
> flicker, only delete and refresh the display line when it changes. An
> earlier version of this code is here:
> https://lore.kernel.org/lkml/20240701044236.475098-1-irogers@google.com/
>
> Add a signal handler for perf tests so that unexpected signals are
> displayed and test clean up is possible.
>
> In perf test add an "exclusive" flag that causes a test to be run with
> no other test. Set this flag manually for C tests and via a
> "(exclusive)" in the test description for shell tests. Add the flag to
> shell tests that may fail when run with other tests.
>
> Change the perf test loop to run in two passes. For parallel
> execution, the first pass runs all tests that can be run in parallel
> then the 2nd runs remaining tests sequentially. This causes the
> "exclusive" tests to be run last and with test numbers moderately out
> of alignment.
>
> Change the default to be to run tests in parallel. Running tests in
> parallel brings the execution time down to less than half.
>
> v5: Make width robust to signal delivery (Namhyung). Minor signal
> print message tweaks and test kill value.
>
> v4: Add patch to sort exclusive tests last, this allows for increasing
> test numbers as requested by Namhyung.
>
> v3: Mark additional shell tests as "(exclusive)" to avoid issues with
> shared resources suggested by Namhyung. Add dependent signal
> handler change so that kill/ctrl-C don't leave lots of processes,
> previously sent here:
> https://lore.kernel.org/lkml/20241017052137.225514-1-irogers@google.com/
>
> v2: Fix inaccurate remaining counts when running specific
> tests. Rename "remaining" to "active" to better reflect the
> testing behavior. Move the exclusive flag to test cases and not
> entire suites. Add more "(exclusive)" flags to test as
> suggested-by James Clark. Remove "(exclusive)" flag from test
> descriptions to keep the command line output more concise. Add
> James Clark's tested-by.
>
> Ian Rogers (10):
> tools subcmd: Add non-waitpid check_if_command_finished()
> perf test: Display number of active running tests
> perf test: Reduce scope of parallel variable
> perf test: Avoid list test blocking on writing to stdout
> perf test: Tag parallel failing shell tests with "(exclusive)"
> perf test: Add a signal handler around running a test
> perf test: Run parallel tests in two passes
> perf test: Make parallel testing the default
> perf test: Add a signal handler to kill forked child processes
> perf test: Sort tests placing exclusive tests last
Tested-by : Athira Rajeev <atrajeev@...ux.vnet.ibm.com <mailto:atrajeev@...ux.vnet.ibm.com>>
Thanks
Athira Rajeev
>
> tools/lib/subcmd/run-command.c | 33 ++
> tools/perf/tests/builtin-test.c | 408 ++++++++++++------
> .../tests/shell/coresight/asm_pure_loop.sh | 2 +-
> .../shell/coresight/memcpy_thread_16k_10.sh | 2 +-
> .../coresight/thread_loop_check_tid_10.sh | 2 +-
> .../coresight/thread_loop_check_tid_2.sh | 2 +-
> .../shell/coresight/unroll_loop_thread_10.sh | 2 +-
> tools/perf/tests/shell/list.sh | 5 +-
> .../tests/shell/perftool-testsuite_report.sh | 2 +-
> tools/perf/tests/shell/probe_vfs_getname.sh | 2 +-
> .../shell/record+script_probe_vfs_getname.sh | 2 +-
> tools/perf/tests/shell/record.sh | 2 +-
> tools/perf/tests/shell/record_lbr.sh | 2 +-
> tools/perf/tests/shell/record_offcpu.sh | 2 +-
> tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
> tools/perf/tests/shell/stat_bpf_counters.sh | 2 +-
> tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
> .../tests/shell/test_arm_coresight_disasm.sh | 2 +-
> tools/perf/tests/shell/test_arm_spe.sh | 2 +-
> tools/perf/tests/shell/test_data_symbol.sh | 2 +-
> tools/perf/tests/shell/test_intel_pt.sh | 2 +-
> .../perf/tests/shell/test_stat_intel_tpebs.sh | 2 +-
> .../tests/shell/trace+probe_vfs_getname.sh | 2 +-
> tools/perf/tests/task-exit.c | 9 +-
> tools/perf/tests/tests-scripts.c | 7 +-
> tools/perf/tests/tests.h | 9 +
> tools/perf/util/color.h | 1 +
> 27 files changed, 367 insertions(+), 145 deletions(-)
>
> --
> 2.47.0.163.g1226f6d8fa-goog
>
Powered by blists - more mailing lists