linux-kernel - Re: [PATCH v5 05/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029191623.GYZyE0h3364vdHHoxP@fat_crate.local>
Date: Tue, 29 Oct 2024 20:16:23 +0100
From: Borislav Petkov <bp@...en8.de>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	x86@...nel.org, "Gautham R . Shenoy" <gautham.shenoy@....com>,
	Perry Yuan <perry.yuan@....com>, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-pm@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH v5 05/13] platform/x86: hfi: Introduce AMD Hardware
 Feedback Interface Driver

On Sun, Oct 27, 2024 at 09:02:43PM -0500, Mario Limonciello wrote:
> +static int __init amd_hfi_init(void)
> +{
> +	int ret;
> +
> +	if (acpi_disabled ||
> +	    !boot_cpu_has(X86_FEATURE_AMD_HETEROGENEOUS_CORES) ||
> +	    !boot_cpu_has(X86_FEATURE_AMD_WORKLOAD_CLASS))

s/boot_cpu_has/cpu_feature_enabled/g

Audit your whole set pls.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette