linux-kernel - Re: [PATCH] sunrpc: remove newlines from tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <699aa2947387314d842d322c6c57030e8dd58c15.camel@kernel.org>
Date: Tue, 29 Oct 2024 15:42:00 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Chuck Lever <chuck.lever@...cle.com>, Trond Myklebust
	 <trondmy@...merspace.com>, Anna Schumaker <anna@...nel.org>
Cc: Neil Brown <neilb@...e.de>, Olga Kornievskaia <okorniev@...hat.com>, Dai
 Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, Steven Rostedt
 <rostedt@...dmis.org>,  Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>,  linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] sunrpc: remove newlines from tracepoints

On Tue, 2024-10-29 at 15:39 -0400, Chuck Lever wrote:
> On Tue, Oct 29, 2024 at 03:21:43PM -0400, Jeff Layton wrote:
> > Tracepoint strings don't require newlines (and in fact, they are
> > undesirable).
> > 
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > ---
> >  include/trace/events/sunrpc.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
> > index 5e8495216689549f1c0bb377911eac4a7bb7b1a8..b13dc275ef4a79940a940dd463b7a3eef5ca428b 100644
> > --- a/include/trace/events/sunrpc.h
> > +++ b/include/trace/events/sunrpc.h
> > @@ -719,7 +719,7 @@ TRACE_EVENT(rpc_xdr_overflow,
> >  	),
> >  
> >  	TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> > -		  " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> > +		  " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> >  		__entry->task_id, __entry->client_id,
> >  		__get_str(progname), __entry->version, __get_str(procedure),
> >  		__entry->requested, __entry->p, __entry->end,
> > @@ -777,7 +777,7 @@ TRACE_EVENT(rpc_xdr_alignment,
> >  	),
> >  
> >  	TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> > -		  " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> > +		  " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> >  		__entry->task_id, __entry->client_id,
> >  		__get_str(progname), __entry->version, __get_str(procedure),
> >  		__entry->offset, __entry->copied,
> > 
> > ---
> > base-commit: 9c9cb4242c49bbadd010e8f0a9e7daf4b392ff6b
> > change-id: 20241029-tpfix-252e1f852ae4
> > 
> > Best regards,
> > -- 
> > Jeff Layton <jlayton@...nel.org>
> > 
> 
> Looks like a client-side trace point.
> 
> Acked-by: Chuck Lever <chuck.lever@...cle.com>
> 

Anna, Trond, would you mind picking this one up?

Thanks,
-- 
Jeff Layton <jlayton@...nel.org>