linux-kernel - [PATCH v4 0/3] memory,x86,acpi: hotplug memory alignment advisement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029202041.25334-1-gourry@gourry.net>
Date: Tue, 29 Oct 2024 16:20:38 -0400
From: Gregory Price <gourry@...rry.net>
To: x86@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org,
	linux-mm@...ck.org
Cc: linux-cxl@...r.kernel.org,
	Jonathan.Cameron@...wei.com,
	dan.j.williams@...el.com,
	rrichter@....com,
	Terry.Bowman@....com,
	dave.jiang@...el.com,
	ira.weiny@...el.com,
	alison.schofield@...el.com,
	gourry@...rry.net,
	dave.hansen@...ux.intel.com,
	luto@...nel.org,
	peterz@...radead.org,
	tglx@...utronix.de,
	mingo@...hat.com,
	bp@...en8.de,
	hpa@...or.com,
	rafael@...nel.org,
	lenb@...nel.org,
	david@...hat.com,
	osalvador@...e.de,
	gregkh@...uxfoundation.org,
	akpm@...ux-foundation.org,
	rppt@...nel.org
Subject: [PATCH v4 0/3] memory,x86,acpi: hotplug memory alignment advisement

When physical address regions are not aligned to memory block size,
the misaligned portion is lost (stranded capacity).

Block size (min/max/selected) is architecture defined. Most architectures
tend to use the minimum block size or some simplistic heurist. On x86,
memory block size increases up to 2GB, and is otherwise fitted to the
alignment of non-hotplug (special purpose memory).

CXL exposes its memory for management through the ACPI CEDT (CXL Early
Detection Table) in a field called the CXL Fixed Memory Window.  Per
the CXL specification, this memory must be aligned to at least 256MB.

When a CFMW aligns on a size less than the block size, this causes a
loss of up to 2GB per CFMW on x86.  It is not uncommon for CFMW to be
allocated per-device - though this behavior is BIOS defined.

This patch set provides 3 things:
 1) implement advise/query functions in driverse/base/memory.c to
    report/query architecture agnostic hotplug block alignment advice.
 2) update x86 memblock size logic to consider the hotplug advice
 3) add code in acpi/numa/srat.c to report CFMW alignment advice

The advisement interfaces are design to be called during arch_init
code prior to allocator and smp_init.  start_kernel will call these
through setup_arch() (via acpi and mm/init_64.c on x86), which occurs
prior to mm_core_init and smp_init - so no need for atomics.

There's an attempt to signal callers to advise() that probe has already
occurred, but this is predicated on the notion that query actually
occurs (which presently only happens on x86 and acpi logic). This is
to assist debugging future users.

Once probe is called the first time, it will always return the same value.

Interfaces return -EBUSY and 0 respectively on systems without hotplug.

v4:
- nits and renames
- consolidate srat logic into existing iterator
- remove lock-in call from srat code

Suggested-by: Ira Weiny <ira.weiny@...el.com>
Suggested-by: David Hildenbrand <david@...hat.com>
Suggested-by: Dan Williams <dan.j.williams@...el.com>
Signed-off-by: Gregory Price <gourry@...rry.net>

Gregory Price (3):
  memory: implement memory_block_advise/probe_max_size
  x86: probe memory block size advisement value during mm init
  acpi,srat: give memory block size advice based on CFMWS alignment

 arch/x86/mm/init_64.c    | 16 +++++++++-----
 drivers/acpi/numa/srat.c | 19 ++++++++++++++--
 drivers/base/memory.c    | 48 ++++++++++++++++++++++++++++++++++++++++
 include/linux/memory.h   | 10 +++++++++
 4 files changed, 85 insertions(+), 8 deletions(-)

-- 
2.43.0