linux-kernel - Re: [PATCH v6 4/4] checkpatch: warn on empty rust doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72noG77qLF1WcRu4qJNboyqs9Xvvu_ZmjVN8qitK_MNWnw@mail.gmail.com>
Date: Tue, 29 Oct 2024 21:32:27 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Hridesh MG <hridesh699@...il.com>, Joe Perches <joe@...ches.com>, 
	Andy Whitcroft <apw@...onical.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Andreas Hindborg <a.hindborg@...nel.org>, Boqun Feng <boqun.feng@...il.com>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Dwaipayan Ray <dwaipayanray1@...il.com>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>, Jens Axboe <axboe@...nel.dk>, 
	Wedson Almeida Filho <walmeida@...rosoft.com>, Valentin Obst <kernel@...entinobst.de>, 
	Patrick Miller <paddymills@...ton.me>, Alex Mantel <alexmantel93@...lbox.org>, 
	Matt Gilbride <mattgilbride@...gle.com>, Aswin Unnikrishnan <aswinunni01@...il.com>, 
	Martin Rodriguez Reboredo <yakoyoku@...il.com>, FUJITA Tomonori <fujita.tomonori@...il.com>
Subject: Re: [PATCH v6 4/4] checkpatch: warn on empty rust doc comments

On Tue, Oct 29, 2024 at 7:12 AM Hridesh MG <hridesh699@...il.com> wrote:
>
> Just dropping a gentle ping—please let me know if there’s anything
> additional I can do to help move this forward.

I think Joe wanted to take a look (?), but maybe I misinterpreted his message:

    https://lore.kernel.org/rust-for-linux/9a8ed16ffc65d587ed2ff2d1e95bd61fdca5cc90.camel@perches.com/

The Rust changes (patch #1 and #3) look fine, of course. If needed, I
can take those independently to reduce the series. Otherwise, if
And/Joe want to carry them:

Acked-by: Miguel Ojeda <ojeda@...nel.org>

(Ideally with a slightly better commit message, e.g. one idea is
showing the warning without cleaning those, but up to him to reword or
not if he picks them up)

Thanks!

Cheers,
Miguel