linux-kernel - Re: [PATCH v2 bpf 1/2] bpf: Fix out-of-bounds write in trie_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173023502951.818655.12095228890025333064.git-patchwork-notify@kernel.org>
Date: Tue, 29 Oct 2024 20:50:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Byeonguk Jeong <jungbu2855@...il.com>
Cc: toke@...nel.org, ast@...nel.org, daniel@...earbox.net,
 houtao@...weicloud.com, yonghong.song@...ux.dev,
 linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v2 bpf 1/2] bpf: Fix out-of-bounds write in
 trie_get_next_key()

Hello:

This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Sat, 26 Oct 2024 14:02:43 +0900 you wrote:
> trie_get_next_key() allocates a node stack with size trie->max_prefixlen,
> while it writes (trie->max_prefixlen + 1) nodes to the stack when it has
> full paths from the root to leaves. For example, consider a trie with
> max_prefixlen is 8, and the nodes with key 0x00/0, 0x00/1, 0x00/2, ...
> 0x00/8 inserted. Subsequent calls to trie_get_next_key with _key with
> .prefixlen = 8 make 9 nodes be written on the node stack with size 8.
> 
> [...]

Here is the summary with links:
  - [v2,bpf,1/2] bpf: Fix out-of-bounds write in trie_get_next_key()
    https://git.kernel.org/bpf/bpf/c/13400ac8fb80
  - [v2,bpf,2/2] selftests/bpf: Add test for trie_get_next_key()
    https://git.kernel.org/bpf/bpf/c/d7f214aeacb9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html