linux-kernel - Re: [PATCH 1/1] media: v4l2-subdev: Drop HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyFQx6B6uNepUAoL@kekkonen.localdomain>
Date: Tue, 29 Oct 2024 21:16:55 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Tommaso Merciai <tomm.merciai@...il.com>,
	Martin Hecht <martin.hecht@...et.eu>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Sebastian Reichel <sre@...nel.org>, Zhi Mao <zhi.mao@...iatek.com>,
	Alain Volmat <alain.volmat@...s.st.com>,
	Dave Stevenson <dave.stevenson@...pberrypi.com>,
	Kieran Bingham <kieran.bingham@...asonboard.com>,
	Umang Jain <umang.jain@...asonboard.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Julien Massot <julien.massot@...labora.com>,
	Bingbu Cao <bingbu.cao@...el.com>,
	Jacopo Mondi <jacopo.mondi@...asonboard.com>,
	Nicholas Roth <nicholas@...hemail.net>,
	Paul Elder <paul.elder@...asonboard.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] media: v4l2-subdev: Drop HAS_EVENTS and event
 handlers

Hi Tommaso, Laurent,

On Tue, Oct 29, 2024 at 10:58:49PM +0200, Laurent Pinchart wrote:
> Hi Tommaso,
> 
> Thank you for the patch.
> 
> The subject should start with "media: i2c:", not "media: v4l2-subdev:".
> 
> On Tue, Oct 29, 2024 at 05:21:05PM +0100, Tommaso Merciai wrote:
> > v4l2_subdev_init_finalize() already sets the HAS_EVENTS flag if a
> > control handler is set, and subdev_do_ioctl() uses
> > v4l2_ctrl_subdev_subscribe_event() and v4l2_event_subdev_unsubscribe()
> > as defaults if the subdev doesn't have .(un)subscribe.
> 
> That will be true once patch "[PATCH v2] media: v4l2-subdev: Refactor
> events" gets merged. It's good practice to list dependencies, possibly
> below the --- line (or in a cover letter) if you don't want it to appear
> in the commit message. I also recommend setting the format.useAutoBase
> option to automate recording of the base commit in the patch.

There was some fuzz applying this to the Alvium driver. I've pushed the
result to the devel branch in my git.linuxtv.org tree.

-- 
Regards,

Sakari Ailus