linux-kernel - Re: [PATCH v2 1/2] jiffies: Define secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e4f8c05-45e1-4a92-bfc3-ec66657baa9a@linux.microsoft.com>
Date: Tue, 29 Oct 2024 14:35:25 -0700
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Thomas Gleixner <tglx@...utronix.de>,
 Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: eahariha@...ux.microsoft.com, "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, linux-hyperv@...r.kernel.org,
 Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
 Michael Kelley <mhklinux@...look.com>
Subject: Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

On 10/29/2024 10:25 AM, Thomas Gleixner wrote:
> On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote:
>> On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>>> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote:
>>>> diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h
>>>> index 1220f0fbe5bf..e5256bb5f851 100644
>>>> --- a/include/linux/jiffies.h
>>>> +++ b/include/linux/jiffies.h
>>>> @@ -526,6 +526,8 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m)
>>>>       }
>>>>  }
>>>>
>>>> +#define secs_to_jiffies(_secs) ((_secs) * HZ)
>>>
>>> Can you please make that a static inline, as there is no need for macro
>>> magic like in the other conversions, and add a kernel doc comment which
>>> documents this?
>>
>> Note that a static inline means it cannot be used in e.g. struct initializers,
>> which are substantial users of  "<value> * HZ".
> 
> Bah. That wants to be mentioned in the change log then.
> 
> Still the macro should be documented.
> 
> Thanks,
> 
>         tglx

Thanks for the review, I'll add a kernel doc in v3 and mention the
limitations of an inline function.

- Easwar