linux-kernel - Re: staging: rtl8723bs: change remaining printk to proper api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241029220238.110407-1-rodrigo.gobbi.7@gmail.com>
Date: Tue, 29 Oct 2024 19:02:38 -0300
From: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
To: dan.carpenter@...aro.org
Cc: gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev,
	philipp.g.hortmann@...il.com,
	rodrigo.gobbi.7@...il.com,
	~lkcamp/patches@...ts.sr.ht
Subject: Re: staging: rtl8723bs: change remaining printk to proper api

> Why are you pasing -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA?
> ... But if there is some external document which says to enable it, and it's
> useful stuff then maybe we should keep it?

I've enabled this in an arbitrary way just to check the rtw_dump_raw_rssi_info()
because I was doing the debug replacement within the isolated code. Looking again,
I didn't find any documentation about this and the history of some files, the #ifdef 
macro is very old...from 7years ago. We can remove this for sure.

> If it's not used, just delete it?
Ok, I'll do it in a next patch too.

> ...as you've looked at the
> initialization path and it's okay as you said.
Ok, I'll send a v4.

Tks again and regards!