[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a95a624b-214a-4b1f-ac16-dad5a9270bf8@intel.com>
Date: Tue, 29 Oct 2024 15:10:42 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Andy Lutomirski
<luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
<mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
<dave.hansen@...ux.intel.com>, <x86@...nel.org>, "H. Peter Anvin"
<hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>, Ard Biesheuvel
<ardb@...nel.org>, "Paul E. McKenney" <paulmck@...nel.org>, Josh Poimboeuf
<jpoimboe@...nel.org>, Xiongwei Song <xiongwei.song@...driver.com>, Xin Li
<xin3.li@...el.com>, "Mike Rapoport (IBM)" <rppt@...nel.org>, Brijesh Singh
<brijesh.singh@....com>, Michael Roth <michael.roth@....com>, Tony Luck
<tony.luck@...el.com>, "Kirill A. Shutemov"
<kirill.shutemov@...ux.intel.com>, Alexey Kardashevskiy <aik@....com>
CC: Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...nel.org>, "Pawan
Gupta" <pawan.kumar.gupta@...ux.intel.com>, Daniel Sneddon
<daniel.sneddon@...ux.intel.com>, Kai Huang <kai.huang@...el.com>, "Sandipan
Das" <sandipan.das@....com>, Breno Leitao <leitao@...ian.org>, Rick Edgecombe
<rick.p.edgecombe@...el.com>, Alexei Starovoitov <ast@...nel.org>, Hou Tao
<houtao1@...wei.com>, Juergen Gross <jgross@...e.com>, Vegard Nossum
<vegard.nossum@...cle.com>, Kees Cook <kees@...nel.org>, Eric Biggers
<ebiggers@...gle.com>, Jason Gunthorpe <jgg@...pe.ca>, "Masami Hiramatsu
(Google)" <mhiramat@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>,
Luis Chamberlain <mcgrof@...nel.org>, Yuntao Wang <ytcoode@...il.com>,
"Rasmus Villemoes" <linux@...musvillemoes.dk>, Christophe Leroy
<christophe.leroy@...roup.eu>, Tejun Heo <tj@...nel.org>, Changbin Du
<changbin.du@...wei.com>, Huang Shijie <shijie@...amperecomputing.com>,
"Geert Uytterhoeven" <geert+renesas@...der.be>, Namhyung Kim
<namhyung@...nel.org>, Arnaldo Carvalho de Melo <acme@...hat.com>,
<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-efi@...r.kernel.org>
Subject: Re: [PATCH v5 05/16] x86/cpu: Defer CR pinning setup until after EFI
initialization
On 10/28/2024 9:07 AM, Alexander Shishkin wrote:
> In order to map the EFI runtime services, set_virtual_address_map
> needs to be called, which resides in the lower half of the address
> space. This means that LASS needs to be temporarily disabled around
> this call. This can only be done before the CR pinning is set up.
>
...
>
> /*
> * This needs to follow the FPU initializtion, since EFI depends on it.
> + * It also needs to precede the CR pinning setup, because we need to be
> + * able to temporarily clear the CR4.LASS bit in order to execute the
> + * set_virtual_address_map call, which resides in lower addresses and
> + * would trip LASS if enabled.
> */
It would be helpful to describe why lass_stac()/clac() doesn't work here
and instead the heavy handed CR4 toggling is needed.
> if (efi_enabled(EFI_RUNTIME_SERVICES))
> efi_enter_virtual_mode();
>
> + setup_cr_pinning();
> +
Powered by blists - more mailing lists