linux-kernel - Re: [PATCHv2 net-next] net: bnxt: use ethtool string helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241029154943.381c105d@kernel.org>
Date: Tue, 29 Oct 2024 15:49:43 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCHv2 net-next] net: bnxt: use ethtool string helpers

On Tue, 22 Oct 2024 12:37:37 -0700 Rosen Penev wrote:
>  	struct bnxt *bp = netdev_priv(dev);
> -	static const char * const *str;
> +	const char *str;
>  	u32 i, j, num_str;

please respect reverse xmas tree variable declaration ordering
Since the line declaring str is now shortest it should go to the end.
-- 
pw-bot: cr