linux-kernel - Re: [PATCH net-next] net: broadcom: use ethtool string helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029160323.532e573c@kernel.org>
Date: Tue, 29 Oct 2024 16:03:23 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Justin Chen <justin.chen@...adcom.com>, Florian
 Fainelli <florian.fainelli@...adcom.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
 Rafał Miłecki <rafal@...ecki.pl>, Sudarsana Kalluru
 <skalluru@...vell.com>, Manish Chopra <manishc@...vell.com>, Doug Berger
 <opendmb@...il.com>, Jacob Keller <jacob.e.keller@...el.com>, Sabrina
 Dubroca <sd@...asysnail.net>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH net-next] net: broadcom: use ethtool string helpers

On Tue, 22 Oct 2024 18:27:34 -0700 Rosen Penev wrote:
> @@ -3220,13 +3212,13 @@ static void bnx2x_get_strings(struct net_device *dev, u32 stringset, u8 *buf)
>  			start = 0;
>  		else
>  			start = 4;
> -		memcpy(buf, bnx2x_tests_str_arr + start,
> -		       ETH_GSTRING_LEN * BNX2X_NUM_TESTS(bp));
> +		for (i = start; i < BNX2X_NUM_TESTS(bp); i++)
> +			ethtool_puts(&buf, bnx2x_tests_str_arr[i]);

I don't think this is equivalent.

Also, please split bnx2x to a separate patch, the other drivers in this
patch IIUC are small embedded ones, the bnx2x is an "enterprise
product".
-- 
pw-bot: cr