[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fa5dd074-0045-4f37-894f-861081f4cfdd@oracle.com>
Date: Tue, 29 Oct 2024 18:03:44 -0500
From: Dave Kleikamp <dave.kleikamp@...cle.com>
To: Ghanshyam Agrawal <ghanshyam1898@...il.com>, osmtendev@...il.com,
ghandatmanas@...il.com, eadavis@...com
Cc: jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
syzbot+5f7f0caf9979e9d09ff8@...kaller.appspotmail.com
Subject: Re: [PATCH] jfs: fix array-index-out-of-bounds in dtInsertEntry
On 10/10/24 8:43AM, Ghanshyam Agrawal wrote:
> The value of p->header.freelist can be less than zero which
> causes an error in dtInsertEntry. Added a check in dtInsert
> to address it.
>
> Reported-by: syzbot+5f7f0caf9979e9d09ff8@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=5f7f0caf9979e9d09ff8
> Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@...il.com>
Looks good. I'll apply this one.
> ---
> fs/jfs/jfs_dtree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c
> index 5d3127ca68a4..51bb3e14551b 100644
> --- a/fs/jfs/jfs_dtree.c
> +++ b/fs/jfs/jfs_dtree.c
> @@ -834,7 +834,7 @@ int dtInsert(tid_t tid, struct inode *ip,
> * the full page.
> */
> DT_GETSEARCH(ip, btstack->top, bn, mp, p, index);
> - if (p->header.freelist == 0)
> + if (p->header.freelist <= 0)
> return -EINVAL;
>
> /*
Powered by blists - more mailing lists