[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZyFrOo7K1qmjtaV5@google.com>
Date: Tue, 29 Oct 2024 16:09:46 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Leo Yan <leo.yan@....com>
Cc: Graham Woodward <graham.woodward@....com>, acme@...nel.org,
mark.rutland@....com, jolsa@...nel.org, irogers@...gle.com,
james.clark@...aro.org, mike.leach@...aro.org, leo.yan@...ux.dev,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, nd@....com
Subject: Re: [PATCH v1 0/4] perf arm-spe: Allow synthesizing of branch
Hi Leo,
On Tue, Oct 29, 2024 at 05:03:46PM +0000, Leo Yan wrote:
> Hi Namhyung,
>
> On Mon, Oct 28, 2024 at 09:40:21AM -0700, Namhyung Kim wrote:
> >
> > Hello,
> >
> > On Fri, Oct 25, 2024 at 03:30:05PM +0100, Graham Woodward wrote:
> > > Currently the --itrace=b will only show branch-misses but this change
> > > allows perf to synthesize branches as well.
> > >
> > > The change also incorporates the ability to display the target
> > > addresses when specifying the addr field if the instruction is a branch.
> > >
> > > Graham Woodward (4):
> > > perf arm-spe: Set sample.addr to target address for instruction sample
> > > perf arm-spe: Use ARM_SPE_OP_BRANCH_ERET when synthesizing branches
> > > perf arm-spe: Correctly set sample flags
> > > perf arm-spe: Update --itrace help text
> >
> > It doesn't apply to perf-tools-next cleanly. Can you please rebase?
>
> I confirmed this series can apply cleanly on the branch [1] with the
> latest commit 150dab31d560 ("perf disasm: Fix not cleaning up
> disasm_line in symbol__disassemble_raw()"):
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git
> branch: perf-tools-next
>
> If you are suggesting for the branch:
>
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git
> branch: perf-tools
>
> You can see it misses some Arm SPE patches which have been picked up
> in the repo [1].
>
> Please kindly suggest what is right thing to do.
Sorry, my bad. It works ok. I'll add it to tmp.perf-tools-next branch
and run some tests.
Thanks,
Namhyung
Powered by blists - more mailing lists