linux-kernel - RE: [PATCH v9 17/26] x86/resctrl: Implement resctrl_arch_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083BDFA959067B4BF62B478FC4B2@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Tue, 29 Oct 2024 23:54:28 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: Babu Moger <babu.moger@....com>, "corbet@....net" <corbet@....net>,
	"Chatre, Reinette" <reinette.chatre@...el.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de"
	<bp@...en8.de>, "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "Yu, Fenghua" <fenghua.yu@...el.com>, "x86@...nel.org" <x86@...nel.org>,
	"hpa@...or.com" <hpa@...or.com>, "thuth@...hat.com" <thuth@...hat.com>,
	"paulmck@...nel.org" <paulmck@...nel.org>, "rostedt@...dmis.org"
	<rostedt@...dmis.org>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "xiongwei.song@...driver.com"
	<xiongwei.song@...driver.com>, "pawan.kumar.gupta@...ux.intel.com"
	<pawan.kumar.gupta@...ux.intel.com>, "daniel.sneddon@...ux.intel.com"
	<daniel.sneddon@...ux.intel.com>, "perry.yuan@....com" <perry.yuan@....com>,
	"sandipan.das@....com" <sandipan.das@....com>, "Huang, Kai"
	<kai.huang@...el.com>, "Li, Xiaoyao" <xiaoyao.li@...el.com>,
	"seanjc@...gle.com" <seanjc@...gle.com>, "Joseph, Jithu"
	<jithu.joseph@...el.com>, "brijesh.singh@....com" <brijesh.singh@....com>,
	"Li, Xin3" <xin3.li@...el.com>, "ebiggers@...gle.com" <ebiggers@...gle.com>,
	"andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
	"mario.limonciello@....com" <mario.limonciello@....com>,
	"james.morse@....com" <james.morse@....com>, "tan.shaopeng@...itsu.com"
	<tan.shaopeng@...itsu.com>, "vikas.shivappa@...ux.intel.com"
	<vikas.shivappa@...ux.intel.com>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "peternewman@...gle.com"
	<peternewman@...gle.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@...el.com>, "Eranian, Stephane" <eranian@...gle.com>,
	"jpoimboe@...nel.org" <jpoimboe@...nel.org>, "thomas.lendacky@....com"
	<thomas.lendacky@....com>
Subject: RE: [PATCH v9 17/26] x86/resctrl: Implement
 resctrl_arch_config_cntr() to assign a counter with ABMC

> +int resctrl_arch_config_cntr(struct rdt_resource *r, struct rdt_mon_domain *d,
> +                          enum resctrl_event_id evtid, u32 rmid, u32 closid,
> +                          u32 cntr_id, bool assign)
> +{
> +     struct rdt_hw_mon_domain *hw_dom = resctrl_to_arch_mon_dom(d);
> +     union l3_qos_abmc_cfg abmc_cfg = { 0 };
> +     struct arch_mbm_state *arch_mbm;
> +
> +     abmc_cfg.split.cfg_en = 1;
> +     abmc_cfg.split.cntr_en = assign ? 1 : 0;
> +     abmc_cfg.split.cntr_id = cntr_id;
> +     abmc_cfg.split.bw_src = rmid;
> +
> +     /* Update the event configuration from the domain */
> +     if (evtid == QOS_L3_MBM_TOTAL_EVENT_ID) {
> +             abmc_cfg.split.bw_type = hw_dom->mbm_total_cfg;
> +             arch_mbm = &hw_dom->arch_mbm_total[rmid];
> +     } else {
> +             abmc_cfg.split.bw_type = hw_dom->mbm_local_cfg;
> +             arch_mbm = &hw_dom->arch_mbm_local[rmid];
> +     }
> +
> +     smp_call_function_any(&d->hdr.cpu_mask, resctrl_abmc_config_one_amd,
> +                           &abmc_cfg, 1);
> +
> +     return 0;
> +}

Compiling with W=1:

warning: variable 'arch_mbm' set but not used [-Wunused-but-set-variable]

[still not used by patch 26]

-Tony