linux-kernel - Re: [PATCH v2] media: v4l2-subdev: Refactor events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyCD5O7BjtvPbFw-@kekkonen.localdomain>
Date: Tue, 29 Oct 2024 06:42:44 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Tommaso Merciai <tomm.merciai@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil@...all.nl>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Paweł Anikiel <panikiel@...gle.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: v4l2-subdev: Refactor events

On Mon, Oct 28, 2024 at 08:36:57PM +0200, Laurent Pinchart wrote:
> > > What I meant is looking at the I2C sensor drivers that currently
> > > 
> > > - call v4l2_subdev_init_finalize()
> > > - set V4L2_SUBDEV_FL_HAS_EVENTS
> > > - set the .subscribe_event() and .unsubscribe_event() handlers
> > > 
> > > and dropping the flag and handlers from them. Is that what you plan to
> > > work on ?
> > 
> > It's ok for you per/driver patch or you prefer a big single patch?
> 
> I'm fine either way. Maybe one large patch to address all the drivers
> where the flag and handlers are simply dropped, and then one patch per
> driver where changes are larger (such as adding calls to
> v4l2_subdev_init_finalize()) ?

Sounds good to me.

-- 
Sakari Ailus