linux-kernel - Re: [EXT] Re: [PATCH v18 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0b9157c-48cd-41a7-ab38-c0334f1e5af7@kernel.org>
Date: Tue, 29 Oct 2024 08:21:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sandor Yu <sandor.yu@....com>
Cc: "dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
 "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
 "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 "jonas@...boo.se" <jonas@...boo.se>,
 "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
 "airlied@...il.com" <airlied@...il.com>, "daniel@...ll.ch"
 <daniel@...ll.ch>, "robh+dt@...nel.org" <robh+dt@...nel.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
 "festevam@...il.com" <festevam@...il.com>,
 "vkoul@...nel.org" <vkoul@...nel.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
 "mripard@...nel.org" <mripard@...nel.org>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>,
 dl-linux-imx <linux-imx@....com>, Oliver Brown <oliver.brown@....com>,
 "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
 "sam@...nborg.org" <sam@...nborg.org>
Subject: Re: [EXT] Re: [PATCH v18 3/8] dt-bindings: display: bridge: Add
 Cadence MHDP8501

On 29/10/2024 08:17, Sandor Yu wrote:
>>
>> On Tue, Oct 29, 2024 at 02:02:11PM +0800, Sandor Yu wrote:
>>> +  interrupts:
>>> +    items:
>>> +      - description: Hotplug cable plugin.
>>> +      - description: Hotplug cable plugout.
>>> +
>>> +  interrupt-names:
>>> +    items:
>>> +      - const: plug_in
>>> +      - const: plug_out
>>> +
>>> +  data-lanes:
>>> +    $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes
>>> +    minItems: 4
>>> +    maxItems: 4
>>> +    description: Lane reordering for HDMI or DisplayPort interface.
>>
>> Please look how existing bindings do it. data-lanes is a property of port.
>> Otherwise why would you like this to be applied to the input?
> 
> 'lane reordering' is a feature of the MHDP IP, and different boards have different mappings. 

Yeah, and?

> 
> Benjamin comments in v16, the imx8mq-zii-ultra board's lane mapping differs from the default in my driver, 
> so we need to treat it as an input.

But HDMI is not your input port. At least that's what few lines below!
This is confusing.

> 
> As data-lanes is a property of port, so there is no exist property could be reused,

data-lanes, really, what is the problem here?

> How about revert 'data-lanes' back to my previous implementation of 'lane-mapping'?

No.

Best regards,
Krzysztof