linux-kernel - Re: [PATCH 2/3] pinctrl: sophgo: add support for SG2042 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rbb7nlqjvek3tvjtfrqnamp6bbhmdq6fe57ey3pfk4gvks4yd3@rlc3ri4fmxiy>
Date: Tue, 29 Oct 2024 08:30:20 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>, 
	Inochi Amaoto <inochiama@...il.com>
Cc: Chen Wang <unicorn_wang@...look.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Inochi Amaoto <inochiama@...look.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Guo Ren <guoren@...nel.org>, 
	Arnd Bergmann <arnd@...db.de>, Yixun Lan <dlan@...too.org>, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 2/3] pinctrl: sophgo: add support for SG2042 SoC

On Mon, Oct 28, 2024 at 02:02:49PM +0100, Linus Walleij wrote:
> On Thu, Oct 24, 2024 at 8:44 AM Inochi Amaoto <inochiama@...il.com> wrote:
> 
> > Add base driver for SG2042 SoC and pin definition.
> >
> > Signed-off-by: Inochi Amaoto <inochiama@...il.com>
> 
> This driver is clearly duplicating a ton of code from pinctrl-cv18xx.c.
> 
> We have no interest in having to fix bugs in two places.
> 
> Please factor out the common code and use the same code
> in the new driver if you can't make the new driver a simple
> subdriver och pinctrl-cv18xx.c.
> 
> Yours,
> Linus Walleij

I will have a try to abstact the different code and reduce the duplicate.

Regards,
Inochi