linux-kernel - RE: [PATCH v5 07/13] iommufd/viommu: Add iommufd_viommu_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52760A2D907B5FEA7618522A8C4B2@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Tue, 29 Oct 2024 08:25:18 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Nicolin Chen <nicolinc@...dia.com>, Zhangfei Gao <zhangfei.gao@...aro.org>
CC: "jgg@...dia.com" <jgg@...dia.com>, "will@...nel.org" <will@...nel.org>,
	"joro@...tes.org" <joro@...tes.org>, "suravee.suthikulpanit@....com"
	<suravee.suthikulpanit@....com>, "robin.murphy@....com"
	<robin.murphy@....com>, "dwmw2@...radead.org" <dwmw2@...radead.org>,
	"baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>, "shuah@...nel.org"
	<shuah@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "iommu@...ts.linux.dev"
	<iommu@...ts.linux.dev>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "eric.auger@...hat.com"
	<eric.auger@...hat.com>, "jean-philippe@...aro.org"
	<jean-philippe@...aro.org>, "mdf@...nel.org" <mdf@...nel.org>,
	"mshavit@...gle.com" <mshavit@...gle.com>,
	"shameerali.kolothum.thodi@...wei.com"
	<shameerali.kolothum.thodi@...wei.com>, "smostafa@...gle.com"
	<smostafa@...gle.com>, "Liu, Yi L" <yi.l.liu@...el.com>, "aik@....com"
	<aik@....com>, "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: [PATCH v5 07/13] iommufd/viommu: Add iommufd_viommu_find_dev
 helper

> From: Nicolin Chen <nicolinc@...dia.com>
> Sent: Monday, October 28, 2024 6:49 AM
> 
> On Sun, Oct 27, 2024 at 11:02:31PM +0800, Zhangfei Gao wrote:
> > On Sat, 26 Oct 2024 at 07:51, Nicolin Chen <nicolinc@...dia.com> wrote:
> > > +/* Caller should xa_lock(&viommu->vdevs) to protect the return value
> */
> > > +struct device *iommufd_viommu_find_dev(struct iommufd_viommu
> *viommu,
> > > +                                      unsigned long vdev_id)
> > > +{
> > > +       struct iommufd_vdevice *vdev;
> > > +
> > > +       lockdep_is_held(&viommu->vdevs.xa_lock);
> > > +
> > > +       vdev = xa_load(&viommu->vdevs, vdev_id);
> > > +       return vdev ? vdev->idev->dev : NULL;
> > > +}
> >
> > Got this error?
> >
> > ld: Unexpected GOT/PLT entries detected!
> > ld: Unexpected run-time procedure linkages detected!
> > ld: drivers/iommu/iommufd/driver.o: in function
> `iommufd_viommu_find_dev':
> > linux/drivers/iommu/iommufd/driver.c:47: undefined reference to
> > `lockdep_is_held'
> > make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1
> > make[1]: *** [/home/linaro/iommufd/linux/Makefile:1166: vmlinux] Error
> 2
> > make: *** [Makefile:224: __sub-make] Error 2
> 
> Should fix it with:
> -	lockdep_is_held(&viommu->vdevs.xa_lock);
> +	lockdep_assert_held(&viommu->vdevs.xa_lock);
> 

with that,

Reviewed-by: Kevin Tian <kevin.tian@...el.com>